release plan: publish-only transitive inclusion and location excludes (CR-0039) - #28
Merged
Merged
Conversation
…s (CR-0039) Add three CLI-only flags to release plan: - --publish-include-found-transitive: include transitive deps already found in the target in the generated publish file only (package file's transitive policy stays governed by --include-found-transitive, unaffected). - --publish-exclude-regex / --publish-exclude-file: exclude assets from the publish file only, matched against location, reusing the existing release.LoadExcludePatterns file format. Always applied regardless of the found-transitive setting. internal/release/plan.go gains ExcludeAssetsByLocation, with ApplyPolicies refactored to reuse it (no behavior change). BuildPlan computes publish assets from the unfiltered per-plan asset list when the new flag is set, then applies the exclude patterns. Non-breaking: default invocation (no new flags) is byte-identical to prior behavior - zero value PublishIncludeFoundTransitive/ PublishExcludePatterns reduce to the existing PublishAssets(envAssets) call. iics publish (execution command) is untouched. Moves CR-0039 to pending/. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019KEFMYHnZwja4rcKZC5Pim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements CR-0039. Adds three CLI-only flags to
release plan:--publish-include-found-transitive: include transitive dependencies already found in the target in the generated publish file only (package file's transitive policy stays governed by--include-found-transitive, unaffected).--publish-exclude-regex/--publish-exclude-file: exclude assets from the publish file only, matched againstlocation, reusing the existingrelease.LoadExcludePatternsfile format. Always applied regardless of the found-transitive setting.internal/release/plan.gogainsExcludeAssetsByLocation, withApplyPoliciesrefactored to reuse it (no behavior change).BuildPlancomputes publish assets from the unfiltered per-plan asset list when the new flag is set, then applies the exclude patterns.Non-breaking: default invocation (no new flags) is byte-identical to prior behavior - zero-value
PublishIncludeFoundTransitive/PublishExcludePatternsreduce to the existingPublishAssets(envAssets)call.iics publish(the execution command) is untouched.Verification
gofmt -s -l .,go build ./...,go vet ./...,go test ./...,go test -race ./internal/release/..., andgolangci-lint run ./...all clean.release plan --helpdiffed before/after: all 9 pre-existing flags byte-identical, only the 3 new flags added.Moves CR-0039 to
pending/.🤖 Generated with Claude Code
https://claude.ai/code/session_019KEFMYHnZwja4rcKZC5Pim