Wait for both coverage uploads before notifying - #289
Merged
Conversation
philipcraig
enabled auto-merge (squash)
September 2, 2026 11:14
jbcoe
approved these changes
Sep 2, 2026
jbcoe
left a comment
Owner
There was a problem hiding this comment.
Thanks for this. The previous setup did confuse me a bit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 72.87% 72.87%
=======================================
Files 9 9
Lines 822 822
Branches 208 208
=======================================
Hits 599 599
Misses 24 24
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov posts the project status after the first upload, so the runtime-only report is compared against a base that also carries the consteval flag and fails the 1% threshold (seen on #282). Set
after_n_builds: 2so the comparison waits for both uploads.