AGENTS.md follow-up - #3912
Open
mcfnord wants to merge 3 commits into
Open
Conversation
mcfnord
changed the title
The Build line offers a CONFIG+=headless serveronly build; the Testing line
then connects a client. That binary rejects -c:
$ ./Jamulus -n -c localhost
./Jamulus: Client only option(s) '--connect' used. See '--help' for help
(exit 1; built from 11a28d5)
One clause closes the contradiction.
CHANGELOG: SKIP
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
'One logical change per PR' and 'smallest change' are line 5, bold, above the fold; 'Builds? Tested?' are the Testing and Always lines. This file is prepended to every prompt, so each repeat costs context on every call. 'See CONTRIBUTING.md' stays in Read when relevant, where it carries a when-to-read note. CHANGELOG: SKIP Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The last bullet was the fragment "Disclose AI-generated text" with no form and no pointer. It now names where the rule is stated rather than restating it, so there is still one copy of the form and it is the one in AGENTS.md.
mcfnord
force-pushed
the
agents-3785-followup
branch
from
August 18, 2026 23:48
71143f6 to
f63cbe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI: Follow-up to #3785, on the invitation there. Three one-line changes; each traces to a point raised in that review, each stands alone, and any can be dropped if it fails the stable-and-general bar.
Nothing here adds a rule to
AGENTS.md: 3 insertions against 3 deletions, so the file gains no line and ends at 654 words against 651 onmain. On #3910 the point was made thatCONTRIBUTING.mdis the primary source of truth, withAGENTS.mdas the guidance to it — so a rule stated only in the agent file is the defect, not the fix. Three candidates that would otherwise have landed here are held forCONTRIBUTING.md: wire-format compatibility, the clang-format lists that have to move together, and treating a code comment or a commit message as a claim like any other.Short description of changes
AGENTS.md:CONFIG+=headless serveronlybinary rejects the Testing line's client — built from11a28d57and run:./Jamulus -n -c localhost→Client only option(s) '--connect' used. See '--help' for help, exit 1. One clause closes the contradiction (raised in review, pljones preferring the plain build).docs/agents/COMMENTING.md: the last bullet was the fragment "Disclose AI-generated text" and now names where the form is stated, rather than carrying a second copy of it.CHANGELOG: SKIP
Context: Fixes an issue?
Follow-up to #3785.
Does this change need documentation? What needs to be documented and how?
No — it is documentation.
Status of this Pull Request
Ready for review. One commit per change, so any line is droppable in isolation.
What is missing until this pull request can be merged?
Maintainer judgment on which lines clear the "stable and general" bar.
Checklist
serveronlybinary rejects-c) was built and run; output above. No code is changed.🤖 This message was written by AI and reviewed by @mcfnord.