Conversation
lijun99
added a commit
to lijun99/isce3
that referenced
this pull request
Aug 23, 2026
gpu_geocode_rasters() for main_diff_ms_band/main_side_band was called with rdr_geometry (stale, non-multilooked) instead of the correctly computed rdr_geometry_iono, producing a shape mismatch that geocoded the ionosphere phase screen as all zeros. Same fix as upstream PR isce-framework#245 by CBurton90 (open, not yet merged) -- independently found via the all-zero geocoded layer, then confirmed against that PR's description.
lijun99
added a commit
to lijun99/isce3
that referenced
this pull request
Sep 16, 2026
gpu_geocode_rasters() for main_diff_ms_band/main_side_band was called with rdr_geometry (stale, non-multilooked) instead of the correctly computed rdr_geometry_iono, producing a shape mismatch that geocoded the ionosphere phase screen as all zeros. Same fix as upstream PR isce-framework#245 by CBurton90 (open, not yet merged) -- independently found via the all-zero geocoded layer, then confirmed against that PR's description.
lijun99
added a commit
to lijun99/isce3
that referenced
this pull request
Sep 18, 2026
gpu_geocode_rasters() for main_diff_ms_band/main_side_band was called with rdr_geometry (stale, non-multilooked) instead of the correctly computed rdr_geometry_iono, producing a shape mismatch that geocoded the ionosphere phase screen as all zeros. Same fix as upstream PR isce-framework#245 by CBurton90 (open, not yet merged) -- independently found via the all-zero geocoded layer, then confirmed against that PR's description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
main_diff_ms_bandmethod and geocoding the resultant ionospheric correction there is a dimension/shape mismatch as the radar geometry argument is not multilooked (rdr_geometry). Using the multilooked geometry (rdr_geometry_iono) corrects this.