Skip to content

#777 test pam_interactive (including multistep capability) automatically - #824

Open
d-w-moore wants to merge 11 commits into
irods:mainfrom
d-w-moore:777.m
Open

#777 test pam_interactive (including multistep capability) automatically#824
d-w-moore wants to merge 11 commits into
irods:mainfrom
d-w-moore:777.m

Conversation

@d-w-moore

Copy link
Copy Markdown
Collaborator

No description provided.

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Test of multistep doesn't yet pass, even when iRODS4j is run, so something is probably wrong with the test setup. Awaiting a branch of irods/irods4j in which ports are exposed to test PRC on a valid setup

@korydraughn

korydraughn commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Is the PAM Interactive test run expected to fail in GitHub Actions? See the following:

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Is the PAM Interactive test run expected to fail in GitHub Actions? See the following:

* https://github.com/irods/python-irodsclient/actions/runs/31617526699/job/94183959927?pr=824

No, it should pass ... looking

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Is the PAM Interactive test run expected to fail in GitHub Actions? See the following:

* https://github.com/irods/python-irodsclient/actions/runs/31617526699/job/94183959927?pr=824

No, it should pass ... looking

I can only get it to pass by reverting our change (702f723) to the native handoff from pam_interactive to the native auth phase. If I do that, all tests related to pam_interactive (including my new tests in test012...) pass once again.

Not sure how this should look, for the moment. Will need to study.

@korydraughn

Copy link
Copy Markdown
Contributor

That's fine. Those changes do not need to be part of this PR. Keep them in a separate branch so that we can investigate them later.

@d-w-moore
d-w-moore force-pushed the 777.m branch 3 times, most recently from 57fe12d to 238268a Compare August 14, 2026 09:47
One test for correct 2nd password, another for deliberately munged 2nd password.
(nb, the 2nd password test does an extra check to a pam_userdb.db file to prove
multistep authentication work flows are functioning for the pam_interactive auth scheme.)
@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Waiting for tests to pass. As soon as they do, let's go with a final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants