feat(tokens): update to tokens major release - #31457
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
BenOsodrac
marked this pull request as ready for review
September 17, 2026 16:51
brandyscarney
approved these changes
Sep 17, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
LGTM - just left a few small requests.
Requested on the PR: this file will be updated on next soon. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The design tokens v2 bump defaults font-family to Inter. Revert the hand-edit to the generated ionic.vars.scss and define --token-font-family on html so every $ion-font-family reference resolves to the system stack, surviving the next build.tokens run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Requested on the PR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The lockfile still pointed at a file: path outside the repo, which does not exist on CI runners and broke npm install in build-core. Same integrity hash, so the installed package is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Reports the face Chromium actually resolves for ionic text on the Linux runner. The ionic stack leads with -apple-system and system-ui, neither of which exists there, so the winning face is decided by fontconfig and cannot be read off the stylesheets. Needed before pinning a test font, so the pin matches what CI already renders and costs no new baselines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The configured reporters (html, github) do not echo console output to the job log, but they do print failure messages. Throwing the report is the only way to see it, and the PR build is already red on expected snapshot diffs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
On the Linux CI image the ionic stack resolves to WenQuanYi Zen Hei, a single-weight CJK font, because system-ui is a generic keyword that always matches and Roboto/Helvetica/Arial after it are never consulted. That made weight 500 render as 400 and left local (SF Pro on macOS) and CI looking nothing alike. md and ios were already pinned to embedded test fonts here; ionic was explicitly opted out and reads --token-font-family rather than --ion-font-family, so the existing pin never reached it. Reuse the embedded Roboto (mdTestingFont, weights 400/500/700): zero bytes added, a real medium weight, and the face the ionic stack itself names for non-Apple platforms. Remove the temporary font probe now that it has answered its question. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The core Stencil build regenerates packages/react/src/components/ react-component-lib/ from the installed @stencil/react-output-target, which ships the simple forwardRef. next is ahead of that package and carries the typed cast, so every core build reverts this file. It was swept into the tokens bump commit; restore it and keep this file out of the PR until next updates the output target. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The PR diff is taken against the merge-base, not the tip of next. next changed the props annotation today in the sync with main (1df4160), so restoring this file from the tip made the branch appear to introduce that line. Restore it from the merge-base instead so the file drops out of the PR; a later merge of next will take next's version cleanly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Resolve core/package-lock.json by taking next's lockfile and regenerating the outsystems-design-tokens entry (1.4.2 -> 2.3.0) against the merged package.json, so next's dependency tree is preserved intact and only the tokens subtree differs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
brandyscarney
approved these changes
Sep 21, 2026
Issue number: internal --------- ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Update snapshots due to diffs in tokens major release. ## Does this introduce a breaking change? - [x] Yes - [ ] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Co-authored-by: ionitron <hi@ionicframework.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Does this introduce a breaking change?
Other information