chore(i18n): sync main into translation/jp - #4746
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
translation/jpis three commits behind main, and the Japanese site has 143 broken anchors and 1 broken link. Nearly all of it is one cause: main pinned an explicit id on every English heading in #4742, but the translated copies keep their own heading text, so the generated slug no longer matches the link. 103 of the anchors are the single heading### 仮想プロパティ.What is the new behavior?
Merges main into
translation/jp, taking ja to 0 broken anchors and 0 broken links.## UI コンポーネント {/* #ui-components */}## CSSカスタムプロパティto###docs/api/item.mdxlinked to](/#clickable-items), where the leading slash pointed at the site root instead of the pageDoes this introduce a breaking change?
Other information
Merge this with a merge commit, not a squash. A squash destroys the merge base and every later sync re-conflicts on the whole tree, which is what #4729 had to repair.
The heading levels were the only judgement call. Main never changed them; jp had translated those headings at the wrong depth. Realigning fixes the drift and stops the same 32 conflicts recurring on every future sync, at the cost of changing TOC nesting on those pages. The anchors are fixed either way, since the ids are explicit.
Verified by building main with this branch's content as its
jalocale andonBrokenAnchors: 'throw'enabled. This branch's own preview cannot show any of it: jp builds as a single locale at/docs/, so the doubled-baseUrl and slug-mismatch problems never appear there.57 headings remain unpinned, all in five jp-only files (
react.mdx,layout/grid.mdx,deployment/desktop-app.mdx,developer-resources/books.mdx,studio/setup/installation.mdx). None exists on main, and the docs plugin globs the Englishdocs/, so they never render on the production ja site.