[Feature] Non-Conformance - #12682
Draft
SchrodingersGat wants to merge 23 commits into
Draft
Conversation
SchrodingersGat
commented
Aug 22, 2026
SchrodingersGat
commented
Member
- Implements "non conformance" functionality
- Closes [Feature] Build Order Non Conformance #4860
SchrodingersGat
added
api
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SchrodingersGat
marked this pull request as draft
August 22, 2026 04:01
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #12682 +/- ##
==========================================
- Coverage 86.92% 86.89% -0.04%
==========================================
Files 1462 1464 +2
Lines 98187 98627 +440
Branches 11479 11232 -247
==========================================
+ Hits 85352 85701 +349
- Misses 12771 12860 +89
- Partials 64 66 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Very interesting for bettering MES area of the platform. |
matmair
reviewed
Aug 23, 2026
Comment on lines
+1133
to
+1147
| class NCRMixin: | ||
| """Mixin class for NonConformance (NCR) API endpoints.""" | ||
|
|
||
| queryset = NonConformance.objects.all() | ||
| serializer_class = build.serializers.NonConformanceSerializer | ||
|
|
||
|
|
||
| class NCRListOutputOptions(OutputConfiguration): | ||
| """Output options for the NCRList endpoint.""" | ||
|
|
||
| OPTIONS = [InvenTreeOutputOption('part_detail', default=True)] | ||
|
|
||
|
|
||
| class NCRList(NCRMixin, OutputOptionsMixin, ListCreateAPI): | ||
| """API endpoint for accessing a list of NonConformance (NCR) objects. |
Member
There was a problem hiding this comment.
implementing this via a viewset might be more efficient (see #12317)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.