fix(test): treat *.extension entries as changeable in PSPackageBuilderTest (#201) - #202
Merged
natechadwick merged 1 commit intoSep 8, 2026
Conversation
…rTest (#201) The static reference perc.Baseline.ppkg predates the T2.17.4c json-lib EOL removal (PR #150, commit ba565eb), which migrated the getPagesForCalendar JEXL return type from net.sf.json.JSONArray to com.fasterxml.jackson.databind.node.ArrayNode. That migration updates the pageutils.extension XML descriptor at line 127, so the test now fails with: perc.Baseline: content differs in: [Extension-Java/global/percussion/system/pageutils/pageutils.extension] *.extension files are XML descriptors (file reports all 16 in system/Packages/perc.Baseline/Extension-Java/ as "XML 1.0 document") that legitimately evolve between releases: return types, signatures, deprecations, etc. Add them to the existing changeable-file allowlist next to *.xml, *.js, *.properties, *.html, *.css, *.txt, *.md so descriptor edits no longer require rebuilding the reference package. Verification: - ./mvn-env.sh test -Dtest=PSPackageBuilderTest -pl modules/perc-packages -> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 - ./mvn-env.sh spotless:check -pl modules/perc-packages -> BUILD SUCCESS Closes #201 > Co-Authored by Mavis mavis using minimax/MiniMax-M3 with agent mavis.
natechadwick
approved these changes
Sep 8, 2026
natechadwick
deleted the
bugfix/201-fix-pspackagebuilder-test-extension-allowlist
branch
September 8, 2026 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PSPackageBuilderTest.testAllPackagesMatchReferenceStructurewas failing onperc.Baseline:The reference
perc.Baseline.ppkginmodules/perc-packages/src/test/resources/Packages/Percussion/was built by the original ant-based tool before the T2.17.4c json-lib EOL removal (PR #150, commitba565eb2b9). That PR deliberately migratednet.sf.json.JSONArray→com.fasterxml.jackson.databind.node.ArrayNodeon thegetPagesForCalendarJEXL method, which updates thepageutils.extensionXML descriptor at line 127. Single intentional source-level change:Fix
Add
*.extensiontoPSPackageBuilderTest#isChangeableFile(the existing allowlist already exempts*.xml,*.js,*.properties,*.html,*.css,*.txt,*.md). All 16*.extensionfiles insystem/Packages/perc.Baseline/Extension-Java/arefile-reported asXML 1.0 document, so they belong in the same changeable bucket as*.xml. Future descriptor edits (return types, signatures, deprecations) will be tolerated without rebuilding the reference package.Verification
./mvn-env.sh test -Dtest=PSPackageBuilderTest -pl modules/perc-packages→Tests run: 1, Failures: 0, Errors: 0, Skipped: 0(all reference packages now reportOK:)../mvn-env.sh spotless:check -pl modules/perc-packages→ BUILD SUCCESS.Closes #201