Skip to content

perc_decoration.css !important fixed grid breaks responsive themes in editor/preview (8.1.7) #2

Description

@natechadwick-intsof

Summary

8.1.7 changed WebUI/war/css/perc_decoration.css so CMS editor (and often preview) force the legacy fixed region grid with !important:

.vspan_2 { height : 120px !important; min-height: 0 !important; }
/* … vspan_4/6/8 … */
.hspan_2  { width : 160px !important; }
/* … including .hspan_12 { width : 960px !important; } … */

Intent: win over default theme.css min-height after the #757 footer fix so editor placeholders/footer stay put.

Regression: Most customers use responsive themes that set:

.vspan_* { height: auto }
.hspan_* { width: auto }

Decoration loads with the theme in editor/preview, so product !important overrides those rules. Published often stays fine (no decoration on live HTML); editor + preview look broken (clipped header regions, forced ~960px width, wrong layout).

A more correct fix would likely have used auto (or non-forcing) region sizing in decoration rather than hard-locking the old Percussion pixel grid with !important. Most sites are not on the stock fixed grid anymore.

Customer confirmation

  • https://www.cloud.edu/ (Cloud County Community College)
  • Theme Cloud-County-CC/cccc-theme.css uses height: auto / width: auto on all vspan/hspan classes
  • Post-8.1.7: editor + preview broken; published OK
  • Confirmed fix: theme counter-override with height/width: auto !important restoring responsive regions in CMS chrome

Proposed fix (8.1.x / this repo)

  1. Revisit perc_decoration.css region rules: remove !important fixed pixel grid, or switch to auto / placeholder-only sizing that does not fight responsive themes.
  2. Keep published #757 behavior for default theme if still required (min-height growth)—do not require every customer theme to absorb the editor pixel grid.
  3. Ship release note + short support snippet for sites already on 8.1.7+ until a patch lands.
  4. Test: responsive theme with span auto — editor/preview match published layout intent.

Acceptance criteria

  • Responsive auto themes no longer need a customer !important override to look correct in editor/preview
  • Default-theme published footer/#757 behavior re-checked
  • Patch note for 8.1.7+ line

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions