Prevent path parameters from masking invalid query parameters - #481
Open
ydah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAPI 3 request validation merges path parameters into query parameters before validating them. When both locations declare the same name, the path value masks invalid or missing required query values and overwrites the query value after validation.
Pass only query parameters to
validate_request_parameter, which validates queries and headers. Path parameters are already validated separately bycoerce_path_parameter. Application-facing merged parameters retain their existing precedence.Add GET and POST regression coverage for invalid values, missing required queries, independent coercion, and disabled query coercion. Update middleware assertions to verify that query values remain separate from path values.