feat: enable extract and control commands to access non-repeated Crash Log sources - #104
Merged
Merged
Conversation
psurply
changed the title
This patch includes `discover_distinct` method in the CrashLogSource API. This is a discovery method but as a difference with `discover` this one is avoiding the return of repeated sources, which is the case of the PMT sys class and PMT BDF sources. The usage of this method is for the automatic discovery when executing a control command or extracting and avoiding extracting data twice or sending the control command twice Signed-off-by: Rivas Paz, Jose L <jose.l.rivas.paz@intel.com>
This patch enables the CLI to execute a control command on all the discoverable endpoints when no parameter was indicated with "-s" There is another change in the extraction flow as well, where the extracted data from PMT devices will be done only for the sys class PMT devices and not from the BDF devices. Signed-off-by: Rivas Paz, Jose L <jose.l.rivas.paz@intel.com>
jlrivasp
force-pushed
the
dev/default_control
branch
from
September 4, 2026 16:48
e291a7f to
c918e28
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: enable
extractand control commands to access non-repeated Crash Log sourcesThis patch enables
extractcommand to collect all discovered Crash Logsources when no -s parameter is provided and avoids to collect sources
that are mapped several times (e.g. BDF and sys class PMT sources):
This change also impact the control commands; the CLI will execute the
control command in all discovered Crash Log sources avoiding to execute
the command twice in the repeated sources:
This patch also includes
discover_distinctmethod in the CrashLogSourceAPI, which is used to handle the logic to avoid returning these sources
that are mapped to 2 different endpoints
Signed-off-by: Rivas Paz, Jose L jose.l.rivas.paz@intel.com