Skip to content

chore: more \(x) - #2880

Open
maelle wants to merge 1 commit into
rversionyoungerfrom
rversionyoungerstill
Open

chore: more \(x)#2880
maelle wants to merge 1 commit into
rversionyoungerfrom
rversionyoungerstill

Conversation

@maelle

@maelle maelle commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a87807a is merged into rversionyounger:

  • ✔️as_adjacency_matrix: 570ms -> 567ms [-3.32%, +2.09%]
  • ✔️as_biadjacency_matrix: 600ms -> 597ms [-3.91%, +2.87%]
  • ✔️as_data_frame_both: 1.21ms -> 1.23ms [-0.76%, +4%]
  • ✔️as_long_data_frame: 3.05ms -> 2.99ms [-4.41%, +0.57%]
  • ✔️es_attr_filter: 2.06ms -> 2.06ms [-2.59%, +2.63%]
  • ✔️graph_from_adjacency_matrix: 125ms -> 121ms [-6.63%, +1.02%]
  • ✔️graph_from_data_frame: 2.75ms -> 2.74ms [-3.66%, +2.83%]
  • ✔️vs_attr_filter: 1.11ms -> 1.11ms [-2.39%, +2.29%]
  • ✔️vs_by_name: 753µs -> 764µs [-1.85%, +4.69%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@maelle
maelle requested review from schochastics and removed request for schochastics September 8, 2026 08:05

@krlmlr krlmlr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to stay away from that for now.

Comment thread R/aaa-cliques.R
},
error = function(e) e,
interrupt = function(e) e
error = \(e) e,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error = \(e) e,
error = identity,

@krlmlr
krlmlr force-pushed the rversionyoungerstill branch from a87807a to 2df2808 Compare September 10, 2026 08:54
@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2df2808 is merged into rversionyounger:

  • ✔️as_adjacency_matrix: 244ms -> 243ms [-0.87%, +0.38%]
  • ✔️as_biadjacency_matrix: 256ms -> 252ms [-2.84%, +0.21%]
  • ✔️as_data_frame_both: 264ms -> 264ms [-0.73%, +0.63%]
  • ✔️as_long_data_frame: 211ms -> 211ms [-0.77%, +0.81%]
  • ✔️es_attr_filter: 243ms -> 244ms [-0.31%, +0.65%]
  • ✔️graph_from_adjacency_matrix: 273ms -> 275ms [-0.39%, +1.88%]
  • ✔️graph_from_data_frame: 286ms -> 285ms [-1%, +0.72%]
  • ✔️vs_attr_filter: 316ms -> 317ms [-0.14%, +0.99%]
  • ✔️vs_by_name: 315ms -> 311ms [-3.73%, +1.01%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants