docs(client): note ALPN/connector decides HTTP/1 vs HTTP/2 - #4200
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
Clarify that after TLS ALPN (or equivalent connector metadata), the negotiated protocol is final: call http1::handshake or http2::handshake accordingly. Request::version does not select the connection protocol. Fixes hyperium#2717
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2717.
Summary
client::connthat ALPN / the connector chooses HTTP/1 vs HTTP/2 and that choice is final for the connection.Request/Versiondoes not select the protocol at this layer (same rule for higher-level clients such as hyper-util's legacyClient).clientmodule docs.Docs only; no behavior change.
Validation
git applyclean onmaster@e89d0d93d956git diff --checkcargo doc -p hyper --no-deps --features full(optional)AI disclosure