fix(deps): bump js-yaml override to 4.3.2 (GHSA-2883-xcg3-v3hh) - #339
Merged
Merged
Conversation
js-yaml < 4.3.2 has a DoS vulnerability where maxTotalMergeKeys fails to properly bound CPU usage when a YAML document repeatedly merges empty mappings, letting a small crafted document cause prolonged CPU consumption. Bump the js-yaml override from ^4.3.1 to ^4.3.2 to pick up the fix, which counts each merge-source mapping as a budget unit. Verified full test suite (843 tests) still passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016yFmmydHNhbvrmnvVtEuXZ
htilly
marked this pull request as ready for review
September 14, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes GHSA-2883-xcg3-v3hh, a Dependabot alert flagged on this repo's default branch.
js-yamlversions>= 4.0.0, < 4.3.2(and>= 3.0.0, < 3.15.2) have a denial-of-service vulnerability: themaxTotalMergeKeyslimit fails to properly bound CPU usage when a YAML document repeatedly merges empty mappings, so a small, crafted YAML document can cause prolonged CPU consumption despite the configured limit. The fix counts each merge-source mapping as a budget unit in addition to its keys.This repo already pinned
js-yamlvia theoverridesfield, but to the vulnerable^4.3.1, which resolved tojs-yaml@4.3.1.Changes
package.json: bump thejs-yamloverride from^4.3.1to^4.3.2(the patched version).package-lock.json: regenerated to resolvejs-yamlto4.3.2.Testing
npm installnpm test— all 843 tests pass.npm auditandpackage-lock.jsonthatjs-yamlnow resolves to4.3.2.🤖 Generated with Claude Code
https://claude.ai/code/session_016yFmmydHNhbvrmnvVtEuXZ
Generated by Claude Code