fix(topics): honor wildcard flag during matching - #1051
Open
Abdulmumin1 wants to merge 2 commits into
Open
Conversation
Contributor
|
That should also impact the destination and tenant object responses and in the postprocess trim out the no longer valid wildcard topics |
Contributor
Author
like before returning the object through the API, remove embedded wildcard topics such as user.* when the flag is disabled. for example, storage contains: ["user.*", "order.created"] with the flag disabled, the API return just: ["order.created"] |
Contributor
|
Yes, otherwise the data is misrepresentative of the behavior and breaks the portal UI! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
makes
TOPICS_ALLOW_WILDCARDSapply during topic matching, not only validation.
when the flag is disabled:
user.*are ignored during delivery matching*still means subscribe to all topics
this also applies to destination filtering, direct destination publishes, and manual retries.
closes TOPICS_ALLOW_WILDCARDS: disabling the flag leaves existing wildcard subscriptions half-working #991