Skip to content

fix(topics): honor wildcard flag during matching - #1051

Open
Abdulmumin1 wants to merge 2 commits into
hookdeck:mainfrom
Abdulmumin1:fix/topics-wildcard-flag-matching
Open

fix(topics): honor wildcard flag during matching#1051
Abdulmumin1 wants to merge 2 commits into
hookdeck:mainfrom
Abdulmumin1:fix/topics-wildcard-flag-matching

Conversation

@Abdulmumin1

Copy link
Copy Markdown
Contributor

summary


makes TOPICS_ALLOW_WILDCARDS apply during topic matching, not only validation.

when the flag is disabled:

@alexbouchardd

Copy link
Copy Markdown
Contributor

That should also impact the destination and tenant object responses and in the postprocess trim out the no longer valid wildcard topics

@Abdulmumin1

Copy link
Copy Markdown
Contributor Author

That should also impact the destination and tenant object responses and in the postprocess trim out the no longer valid wildcard topics

like before returning the object through the API, remove embedded wildcard topics such as user.* when the flag is disabled.

for example, storage contains:

["user.*", "order.created"]

with the flag disabled, the API return just:

["order.created"]

@alexbouchardd

Copy link
Copy Markdown
Contributor

Yes, otherwise the data is misrepresentative of the behavior and breaks the portal UI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TOPICS_ALLOW_WILDCARDS: disabling the flag leaves existing wildcard subscriptions half-working

2 participants