grid/jsx-components - #13
Open
sebastianbochan wants to merge 71 commits into
Open
sebastianbochan wants to merge 71 commits into
sebastianbochan wants to merge 71 commits into
Conversation
components/description
Combine Description with Data, Columns, and Column exports and demo. Co-authored-by: Cursor <cursoragent@cursor.com>
components/data-column
components/pagination-position
components/grid-pro
Pin examples and wrappers to the released CSS fixes, and use exact Vite aliases for workspace packages. Co-authored-by: Cursor <cursoragent@cursor.com>
Update grid-lite and grid-pro packages to 3.1.0.
styling/tailwind
Redesigned README.md files.
KamilKubik
requested changes
Aug 13, 2026
KamilKubik
left a comment
KamilKubik
left a comment
Collaborator
There was a problem hiding this comment.
Overall it looks and works as intendent, excellent work!
I have a few suggestions below:
|
|
||
| // Prevent double initialization | ||
| if (initStartedRef.current || currGridRef.current) { | ||
| return; |
Collaborator
There was a problem hiding this comment.
Not related to the latest changes, but it can create a serious issue when strict mode is on. Because it then mounts twice, there's no proper cleanup (only in the dev environment). I think it would be ideal to always return the cleanup instead.
| ); | ||
| const gridOptions = useMemo( | ||
| () => build(childOptions, options), | ||
| [childOptions, options, ...buildDeps] |
Collaborator
There was a problem hiding this comment.
I strongly recommend installing the eslint-plugin-react-hooks plugin, which should show an error here (and potentially in other places).
Collaborator
Author
There was a problem hiding this comment.
No errors here, only warning. TBD.
Collaborator
There was a problem hiding this comment.
Looks like this on my end 🤔.
grid/components-options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added JSX-based Grid configuration.
TODO
Architecture
Components
Pagination
Layout handling
Header - optional
Tooling / Tests
Grid Pro
Tailwind
Docs
Demos