docs(go): note that GOFLAGS from the host has no effect - #106
Closed
raphaelvigee wants to merge 1 commit into
Closed
docs(go): note that GOFLAGS from the host has no effect#106raphaelvigee wants to merge 1 commit into
raphaelvigee wants to merge 1 commit into
Conversation
heph/heph#448 removed GOFLAGS from the go_golist driver's host passthrough (it changed go list's output without keying the cache, so a cached listing could be served to a build with a different GOFLAGS). Document that build tags belong on a variant's `tags` field, not in the environment. Ref: hephbuild/heph@74d10bc
⚡ Cloudflare Pages preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goplugin does not read the host'sGOFLAGSforgo list/build — build tags belong on a variant'stagsfield instead.website/docs/plugins/go.md) and its Claude Code plugin reference twin (plugins/heph-go/skills/heph-go/references/go-plugin.md), per this repo's reference-drift rule.Why
Triggered by hephbuild/heph@74d10bc (hephbuild/heph#448), which removed
GOFLAGSfrom thego_golistdriver's host environment passthrough.GOFLAGS(-mod=vendor,-tags=…,-buildvcs=…) changed whatgo listreported without being part of the cache key, so a listing cached under oneGOFLAGSvalue could be silently served to a build with a different one. The PR itself calls this out as a behavior change: "a workspace relying on ambientGOFLAGSto influence Go builds stops getting that, silently." This PR adds a short doc note so users don't hit that silently and know where the supported equivalent lives.Test plan
GOFLAGS/the host env passthrough list was previously undocumented anywhere in this site.Ref: hephbuild/heph@74d10bc
Generated by Claude Code