Conversation
Allows an inventory repo to be used as a private karo-custom repo.
Owner
Author
|
This change may require updates to be made to the karo-custom documentation. As users may become overwhelmed when trying to implement a simple custom stack. Or perhaps a new quick start guide would help, which could link to further docs pages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows for the inventory directory to be used with symbolic links. Both the directory itself, and when applicable any custom directories present within.
Notes
The primary purpose of this PR is to serve as a middle ground for users wanting to deploy existing 'manual' Docker compose stack files via Ansible.
Due to the way the compose role works, allowing users to add their own standard
compose.ymlfiles would require a meaningful amount of new code. Code which would work counter to the existing system, add further complexity, and wouldn't provide any meaningful control over the deployed stacks.However, there is still a valid need for 'personal' Docker compose stacks.
Users can now utilise their
karo-inventoryrepo to create the appropriate directories for custom stacks (like they would inside akaro-customrepo). I feel this is now a valid option as one, the karo-cli tool makes creating the directory structure and required files easy. And two, the required defaults files can be extremely minimal.See the following example:
karo-compose/defaults/main/inventory_adhoc/main.yml
karo-compose/defaults/main/inventory_adhoc/busybox.yml
host_vars/homeserver/vault.yml
This new functionality achieves the following:
There is now three separate approaches for Docker compose stacks:
Want to share the stack with others? Create a public
karo-customrepo.Want to deploy a private stack while still using Ansible? Use your existing
karo-inventoryrepo.Want to deploy a standard
compose.ymlfile without making changes? Create the file within/srv/docker/local, and run standard Docker compose commands.Checklist