Implement adaptive chunk sizes / adaptive speed benchmark results - #2427
mr-creditcard wants to merge 17 commits into
Conversation
0bc5c8a to
f9c6e4c
Compare
jessevz
left a comment
There was a problem hiding this comment.
Code looks really good, apart from the small syntax error phpstan picked up and the postgres syntax it looks great. I have not tested the code yet but once these things are fixed I can do a test run. Maybe @s3inlc also want to review this
370b6aa to
01d1b4d
Compare
|
Rebased this PR on master! |
s3inlc
left a comment
There was a problem hiding this comment.
Thanks for creating the PR, there is just some minor thing to adjust, otherwise this should be fine. Though we will have to adjust also in the frontend, so that the config variable can be changed there, so there may be some delay in merging it in here until the frontend also is ready with the change.
|
@s3inlc Frontend PR for this: hashtopolis/web-ui#823 |
01d1b4d to
1c9cca0
Compare
…ken and chunk target time
…ems - to-be-removed.
Addresses requirement mentioned in hashtopolis#729 (comment)
1c9cca0 to
eb8df5f
Compare
s3inlc
left a comment
There was a problem hiding this comment.
Thanks for your adjustments, sorry I missed the <0 comparison in the first review, beside this I think it looks good to merge.
As part of the merge it is needed to adjust the migrations filenames to be adjusted to the current date and time (to keep script order for migrations in master). Can you just set it to an actual date and time together with the small change and then I'll merge shortly after.
Did that just now! |
Perfect, thank you! Sorry that I didn't trigger the workflows earlier, there seems to be a syntax issue with the postgres migration (I think the single quotes are not valid, probably no quotes should be used on the column names). And also PHPstan highlighted something (should be |
This PR is a continuation of the work done by @0xVavaldi in #729. I have cherry-picked their commits and added my own on top in an attempt to keep attribution in place. It addresses issues #551 & #2295.
The aforementioned PR has a number of requirements set by @s3inlc in the comments which have remained unaddressed thusfar, this PR aims to implement these. The changes include:
APISendProgress.php's switch statement overDHashcatStatus. In commit dbd4b32 this logic is moved toTaskUtils.phpinstead and is called with a function call.Did some quick tests with this code and it seems to work fine. Would appreciate someone else testing this as well though!
Closes #551 & #2295.