Skip to content

FE-1509: Surface cycles and initial places across the notebook - #9432

Draft
kube wants to merge 1 commit into
claude/fe-1509-notebook-analyses-algorithmsfrom
claude/fe-1509-notebook-analyses-ui
Draft

FE-1509: Surface cycles and initial places across the notebook#9432
kube wants to merge 1 commit into
claude/fe-1509-notebook-analyses-algorithmsfrom
claude/fe-1509-notebook-analyses-ui

Conversation

@kube

@kube kube commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

🌟 What is the purpose of this PR?

Surfaces the structural analyses from #9431 across the notebook: cycle and initial-place badges in the cell list, rings and markers in the graph explorer, and hover-highlighting that ties the two together.

🔗 Related links

🔍 What does this change?

  • Cell rows gain a tinted ↻N badge for cycle members and a blue initial badge for places the net cannot seed itself; hovering a badge lights the whole cycle up in both the list and the graph.
  • Topological ordering hoists the seed places to the front of the flow, so resource pools read alongside plain sources.
  • In the graph explorer: cycle members carry dashed rings (solid while their cycle is hovered, intra-cycle edges recoloured to match), initial places a hollow token marker inside the node with the label shortened to make room, and the header counts both.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing
    • one patch changeset for the whole stack ships in the top PR

📜 Does this require a change to the docs?

The changes in this PR:

  • are in a state where docs changes are not yet required but will be
    • this is tracked in: the user-docs PR at the top of this stack

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🛡 What tests cover this?

The algorithms are covered in #9431; the badge/ring rendering and hover propagation are exercised manually per the steps below.

❓ How to test this?

  1. Run the Petrinaut storybook, enable Notebook view in the viewport settings, open the SIR example, and switch to Notebook.
  2. Susceptible and Infected carry initial badges; Infected and Infection carry ↻1 badges. Hover a badge — the cycle lights up in the list and the graph.
  3. Switch to Topological order — the two seed places lead the list.

📹 Demo

Screenshot pending — to be added before review.

@kube kube self-assigned this Aug 29, 2026
@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 29, 2026 2:18pm
petrinaut Ready Ready Preview Aug 29, 2026 2:18pm
petrinaut-docs Ready Ready Preview Aug 29, 2026 2:18pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Aug 29, 2026 2:18pm

Request Review

Cell rows gain a tinted ↻ badge for cycle members and a blue initial
badge for places the net cannot seed itself; hovering a badge lights
the whole cycle up in the list and the graph. Topological ordering
hoists the seed places to the front of the flow.

In the graph explorer, cycle members carry dashed rings (solid while
their cycle is hovered, with intra-cycle edges recoloured to match),
initial places a hollow token marker inside the node, and the header
counts both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

1 participant