Skip to content

FE-836: Tile + wire up the network graph component into hash-frontend - #9318

Open
alex-e-leon wants to merge 3 commits into
bm/be-783-wire-the-atlas-into-the-graph-cli-api-proxy-and-embeddingfrom
FE-836-entity-graph-fe-wiring
Open

FE-836: Tile + wire up the network graph component into hash-frontend#9318
alex-e-leon wants to merge 3 commits into
bm/be-783-wire-the-atlas-into-the-graph-cli-api-proxy-and-embeddingfrom
FE-836-entity-graph-fe-wiring

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Wires up the NetworkGraph component defined in ds-components to the new atlas service. Handles parsing the atlas wire format, tile geometry, caching + prefetching + introduces a few changes to the filter bar to support the new graph view.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 27, 2026 3:28pm
3 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Aug 27, 2026 3:28pm
petrinaut Skipped Skipped Aug 27, 2026 3:28pm
petrinaut-docs Skipped Skipped Aug 27, 2026 3:28pm

Request Review

@cursor

cursor Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
New binary wire parsing on untrusted Atlas responses must stay aligned with the server contract; mistakes would break or mis-render the graph, though strict validation and fixture tests mitigate this.

Overview
Introduces a client-side SALTILE / Atlas wire stack under tiled-network-graph/atlas-decode: strict CBOR subset parsing, envelope/slot layout validation, and per-kind decoders for tile, edges, and locate responses (zero-copy typed-array views, request echo checks, trailers/intern tables). Adds manifest/current JSON parsers for session bootstrap and a golden fixture conformance suite against checked-in .saltile bytes.

Adds LocatedEntityPopover, a ds-components/Panda card anchored to selected nodes/edges (types, properties, link endpoints, truncation cues, optional “Go to entity”). Panda include now scans tiled-network-graph/**/* so those styles codegen with the app.

Reviewed by Cursor Bugbot for commit a01be13. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team area/apps labels Aug 25, 2026
@alex-e-leon
alex-e-leon requested a review from CiaranMn August 25, 2026 10:03
@alex-e-leon alex-e-leon changed the title Tile + wire up the network graph component into hash-frontend FE-836: Tile + wire up the network graph component into hash-frontend Aug 25, 2026
@indietyp
indietyp requested review from a team as code owners August 25, 2026 10:57
@indietyp
indietyp force-pushed the FE-836-entity-graph-fe-wiring branch from 91108b1 to 290d366 Compare August 25, 2026 10:57
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs August 25, 2026 10:57 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 25, 2026 10:57 Inactive

{chips.map((chip) => (
<TypeChip key={chip.label} chip={chip} />
))}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type chips use colliding React keys

Low Severity

Type chips are keyed only by chip.label. An entity with two types that share a title (different versions, or distinct types with the same name) gets duplicate keys, so React can reuse the wrong chip and show a stale colour or icon when the selection updates.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0221332. Configure here.

@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs August 27, 2026 10:40 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 27, 2026 10:40 Inactive
@indietyp
indietyp force-pushed the FE-836-entity-graph-fe-wiring branch from eb2d762 to 22d8ec1 Compare August 27, 2026 11:05
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 27, 2026 11:05 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs August 27, 2026 11:05 Inactive
@indietyp
indietyp force-pushed the FE-836-entity-graph-fe-wiring branch from 22d8ec1 to ed6442b Compare August 27, 2026 13:12
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 27, 2026 13:12 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs August 27, 2026 13:12 Inactive
@indietyp
indietyp force-pushed the FE-836-entity-graph-fe-wiring branch from ed6442b to 6b7d213 Compare August 27, 2026 13:21
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs August 27, 2026 13:21 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 27, 2026 13:21 Inactive
@indietyp
indietyp force-pushed the FE-836-entity-graph-fe-wiring branch from 6b7d213 to 57bf52c Compare August 27, 2026 15:05
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs August 27, 2026 15:05 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 27, 2026 15:05 Inactive
@indietyp
indietyp force-pushed the FE-836-entity-graph-fe-wiring branch from 57bf52c to a01be13 Compare August 27, 2026 15:18
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs August 27, 2026 15:18 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut August 27, 2026 15:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

1 participant