Skip to content

feat(watcher): ungate file watcher + wire diff_version bump (#743) - #286

Merged
jeonghun-jj-lee merged 1 commit into
fix/742-contamination-filterfrom
fix/743-watcher-reactivity
Sep 3, 2026
Merged

feat(watcher): ungate file watcher + wire diff_version bump (#743)#286
jeonghun-jj-lee merged 1 commit into
fix/742-contamination-filterfrom
fix/743-watcher-reactivity

Conversation

@jeonghun-jj-lee

Copy link
Copy Markdown
Contributor

Ungate the @parcel/watcher worktree watch (runs by default for git repos), wire the dead file.watcher.updated listener to bump diff_version with 1s debounce, and clean up the deprecated enable flag.

Part of harmoniqs/amicode#741 · Closes harmoniqs/amicode#743

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: f1667185-d13c-4c78-8c23-0afd2c29cab8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Three changes for external-change reactivity in the Files Changed tab:

1. Remove the OPENCODE_EXPERIMENTAL_FILEWATCHER enable-gate — the @parcel/watcher
   worktree watch now runs by default for git repos. The DISABLE gate is preserved
   as opt-out (OPENCODE_EXPERIMENTAL_DISABLE_FILEWATCHER).

2. Wire the dead file.watcher.updated listener in session.tsx to bump diff_version
   for the active session with 1s trailing-edge debounce. This triggers a diff
   refetch when external changes are detected.

3. Clean up: remove the deprecated flag from flag.ts and the desktop app's env.

Closes harmoniqs/amicode#743
@jeonghun-jj-lee
jeonghun-jj-lee force-pushed the fix/743-watcher-reactivity branch from eadd0c1 to a3e0f97 Compare September 3, 2026 16:23
@jeonghun-jj-lee
jeonghun-jj-lee force-pushed the fix/742-contamination-filter branch from aabb9c5 to 0bc684c Compare September 3, 2026 16:23
@jeonghun-jj-lee
jeonghun-jj-lee merged commit 5cfe840 into fix/742-contamination-filter Sep 3, 2026
4 checks passed
jeonghun-jj-lee added a commit that referenced this pull request Sep 3, 2026
)

Three changes for external-change reactivity in the Files Changed tab:

1. Remove the OPENCODE_EXPERIMENTAL_FILEWATCHER enable-gate — the @parcel/watcher
   worktree watch now runs by default for git repos. The DISABLE gate is preserved
   as opt-out (OPENCODE_EXPERIMENTAL_DISABLE_FILEWATCHER).

2. Wire the dead file.watcher.updated listener in session.tsx to bump diff_version
   for the active session with 1s trailing-edge debounce. This triggers a diff
   refetch when external changes are detected.

3. Clean up: remove the deprecated flag from flag.ts and the desktop app's env.

Closes harmoniqs/amicode#743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant