fix(session): derive agent-file filter from tool filediff only (#742) - #285
Merged
Merged
Conversation
Closed
4 tasks
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove patch-part file lists from the agentFilesAbsolute set in session.diff(). Patch parts captured all worktree changes between step-start and step-finish snapshots (including modifications by other sessions or external processes), causing the Files Changed tab to show files the current session never edited. The filter is now derived exclusively from completed tool parts with filediff metadata — the same metadata that edit/write/patch/apply_patch tools already emit. Patch parts retain their snapshot hashes (used for the from/to diff range) but their files arrays no longer feed the filter. Also fix: when the primary diff path (snapshot-based) runs and finds zero net changes, it now returns [] directly instead of falling through to the filediff- accumulation fallback, which would surface stale metadata for reverted files. Closes harmoniqs/amicode#742
jeonghun-jj-lee
force-pushed
the
fix/742-contamination-filter
branch
from
September 3, 2026 16:23
aabb9c5 to
0bc684c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove patch-part file lists from agentFilesAbsolute in session.diff(). The filter is now derived exclusively from tool filediff metadata. Patch parts retain their snapshot hashes but their files arrays no longer feed the filter.
Also: when the primary diff path (snapshot-based) runs, return its result even if empty, instead of falling through to the filediff-accumulation fallback.
Part of harmoniqs/amicode#741 · Closes harmoniqs/amicode#742