feat(review): editable Files Changed panel with CM6 + in-place updates + sidebar fixes - #774
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
force-pushed
the
amico/issue-766-editable-files-changed
branch
from
September 5, 2026 20:28
5660433 to
0ada4a5
Compare
jeonghun-jj-lee
marked this pull request as ready for review
September 5, 2026 20:32
jeonghun-jj-lee
force-pushed
the
amico/issue-766-editable-files-changed
branch
2 times, most recently
from
September 5, 2026 20:45
d3d7cf8 to
0a153af
Compare
…s + sidebar fixes Editable diff view: - CodeMirror 6 split/unified diff editor (EditableDiffView component) - In-place document updates via minimalChanges dispatch (no destroy/recreate) - In-place readOnly toggle via Compartment.reconfigure (no scroll jump) - Auto-save on edit, revert to agent version, concurrent edit detection - Markdown preview toggle for .md files - File-picker dropdown with horizontal scroll for long paths Lock editing while agent is busy: - Yellow lock chip (Harmoniqs accent) centered at top of diff view - readOnly wired through isAgentBusy prop chain - Programmatic updates go through even when readOnly (transactionFilter removed) Sidebar fixes: - Ghost entries for deleted files with strikethrough + restore context menu - Click suppression for ghost entries, post-restore click fix - Drag auto-scroll with requestAnimationFrame loop - 300ms filesystem watcher debounce to prevent flickering - retainContextWhenHidden on webview provider - Redundant section-order render guard Diff pipeline: - mergeServerAndToolDiffs in accumulate-diffs.ts with projectPrefix - applyRenames for file-move tracking - Write tool filediff metadata (diffLines computation) - diff_version bump on tool completion (in fork) - Cross-project file visibility fix Type fixes: - SessionReviewDiffStyle widened to include 'preview' - SnapshotFileDiff type relaxation for diff prop - DiffStyle aligned with SessionReviewDiffStyle - process.env.HOME type narrowing 61 fork-side tests, 2252 amicode tests pass.
jeonghun-jj-lee
force-pushed
the
amico/issue-766-editable-files-changed
branch
from
September 5, 2026 20:50
0a153af to
91f7f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the read-only
@pierre/diffsrenderer in Files Changed with an editable CodeMirror 6 diff view, plus sidebar UX fixes and a scroll-stable in-place update architecture.Editable diff view
minimalChanges()dispatch — no destroy/recreate on content changes, scroll stays putCompartment.reconfigure()— no scroll jump on agent start/endLock editing while agent is busy
readOnlywired throughisAgentBusyprop chainSidebar fixes
requestAnimationFrameloopretainContextWhenHiddenon webview providerDiff pipeline
mergeServerAndToolDiffsinaccumulate-diffs.tswithprojectPrefixapplyRenamesfor file-move trackingfilediffmetadata (diffLinescomputation)diff_versionbump on tool completion (in fork)Type fixes
SessionReviewDiffStylewidened to include"preview"process.env.HOMEtype narrowingTest coverage
Companion PR
opencode fork: harmoniqs/opencode —
feat/issue-766-editable-files-changedbranch (25 commits onlocal/amicode)