Skip to content

fix: Files Changed cross-session contamination + external-change reactivity #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeonghun-jj-lee merged 1 commit into from
Sep 3, 2026
Merged

fix: Files Changed cross-session contamination + external-change reactivity #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 42 additions & 3 deletions ...p-bundle/overlay/packages/session-ui/src/v2/components/session-review-file-preview-v2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { FileIcon } from "@opencode-ai/ui/file-icon"
import { useFileComponent } from "@opencode-ai/ui/context/file"
import { useI18n } from "@opencode-ai/ui/context/i18n"
import { TooltipV2 } from "@opencode-ai/ui/v2/tooltip-v2"
import { Icon } from "@opencode-ai/ui/v2/icon"
import { IconButtonV2 } from "@opencode-ai/ui/v2/icon-button-v2"
import { mediaKindFromPath } from "../../pierre/media"
import { cloneSelectedLineRange, previewSelectedLines } from "../../pierre/selection-bridge"
import { copyTextToClipboard } from "../../util/clipboard"
Expand Down Expand Up @@ -55,6 +57,12 @@ function statusLabel(status: ViewDiff["status"]) {
return "M"
}

function statusTooltip(status: ViewDiff["status"]) {
if (status === "added") return "Added"
if (status === "deleted") return "Deleted"
return "Modified"
}

function statusType(status: ViewDiff["status"]) {
if (status === "added") return "added"
if (status === "deleted") return "deleted"
Expand Down Expand Up @@ -258,11 +266,42 @@ export function SessionReviewFilePreviewV2(props: SessionReviewFilePreviewV2Prop
return (
<>
<div data-slot="session-review-v2-file-header">
<Show when={props.onRefresh}>
{(handler) => (
<TooltipV2 openDelay={500} value="Refresh">
<button
type="button"
aria-label="Refresh"
onClick={handler()}
style={{
display: "flex",
"align-items": "center",
"justify-content": "center",
width: "10px",
height: "10px",
padding: "0",
margin: "0 -4px 0 0",
border: "none",
background: "none",
cursor: "pointer",
color: "var(--icon-base)",
"flex-shrink": "0",
}}
onMouseEnter={(e) => (e.currentTarget.style.color = "var(--icon-hover, var(--icon-base))")}
onMouseLeave={(e) => (e.currentTarget.style.color = "var(--icon-base)")}
>
<Icon name="refresh" size="small" />
</button>
</TooltipV2>
)}
</Show>
<MenuV2.Context>
<MenuV2.Context.Trigger as="div" data-slot="session-review-v2-file-title">
<div data-slot="session-review-v2-file-status" data-type={statusType(view().status)}>
{statusLabel(view().status)}
</div>
<TooltipV2 openDelay={500} value={statusTooltip(view().status)}>
<div data-slot="session-review-v2-file-status" data-type={statusType(view().status)}>
{statusLabel(view().status)}
</div>
</TooltipV2>
<FileIcon node={{ path: props.file, type: "file" }} />
<FileNameWithPicker
file={props.file}
Expand Down
2 changes: 1 addition & 1 deletion packages/app-bundle/overlay/packages/session-ui/src/v2/components/session-review-v2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@
display: flex;
align-items: center;
gap: 8px;
padding: 8px 16px;
padding: 8px 16px 8px 8px;
flex-shrink: 0;
border-bottom: 1px solid var(--border-weaker-base, var(--v2-border-border-weak));
}
Expand Down
4 changes: 4 additions & 0 deletions packages/app-bundle/overlay/packages/ui/src/v2/components/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ const icons = {
viewBox: "0 0 20 20",
body: `<path d="M5.83333 4.16406L2.5 7.4974L5.83333 10.8307M3.33333 7.4974H17.9167V15.4141H10" stroke="currentColor" stroke-linecap="square"/>`,
},
refresh: {
viewBox: "0 0 16 16",
body: `<path d="M12.5 8A4.5 4.5 0 1 1 8 3.5" stroke="currentColor" stroke-width="1.25" stroke-linecap="round"/><path d="M6 1.5L8.5 3.5L6 5.5" transform="rotate(-15 8.5 3.5)" stroke="currentColor" stroke-width="1.25" stroke-linecap="round" stroke-linejoin="round"/>`,
},
archive: {
viewBox: "0 0 16 16",
body: `<path d="M13.1112 13.5555V14.0555H13.6112V13.5555H13.1112ZM2.889 13.5555H2.389L2.389 14.0555H2.889V13.5555ZM3.38901 5.55546L3.38901 5.05546L2.38901 5.05546L2.38901 5.55546L2.88901 5.55546L3.38901 5.55546ZM14.4446 2.44434H14.9446V1.94434L14.4446 1.94434L14.4446 2.44434ZM14.4446 5.55545L14.4446 6.05545L14.9446 6.05545V5.55545H14.4446ZM1.55566 5.55546L1.05566 5.55545L1.05566 6.05546L1.55566 6.05546L1.55566 5.55546ZM1.5557 2.44436L1.5557 1.94436L1.05571 1.94436L1.0557 2.44436ZM13.1112 5.55546H12.6112V13.5555H13.1112H13.6112V5.55546H13.1112ZM2.889 13.5555H3.389L3.38901 5.55546L2.88901 5.55546L2.889 13.5555H2.889ZM14.4446 2.44434H13.9446V5.55545H14.4446H14.9446V2.44434H14.4446ZM1.55566 5.55546L2.05566 5.55547L2.0557 2.44436L1.5557 2.44436L1.05571 2.44435L1.05566 5.55546ZM6.22234 8.22213V8.72213H9.7779V8.22213V7.72213H6.22234V8.22213ZM13.1112 13.5555V13.0555H2.889V13.5555V14.0555H13.1112V13.5555ZM1.5557 2.44436L1.5557 2.94436L14.4446 2.94434L14.4446 2.44434L14.4446 1.94434L1.5557 1.94436L1.5557 2.44436ZM14.4446 5.55545L14.4446 5.05545L1.55566 5.05546L1.55566 6.05546L14.4446 6.05545L14.4446 5.55545Z" fill="currentColor"/>`,
Expand Down
Loading