fix(mcp): prevent byte-slicing multi-byte UTF-8 in excerpt() - #4
Merged
Merged
Conversation
len(s) returns bytes, so s[:n] could split mid-rune for non-ASCII text (emoji, RTF markup in server descriptions, etc.), producing an invalid UTF-8 string that JSON-encodes to garbage or a replacement character. Switch to []rune so the length check and slice both operate on Unicode codepoints.
Owner
|
hey, thanks for the contributions! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
excerpt()useslen(s)(byte count) for the length check ands[:n](byte slice) for truncation. For non-ASCII text — emoji, RTF markup, or non-Latin server descriptions — this splits mid-rune, producing an invalid UTF-8 string that JSON-encodes to garbage or a Unicode replacement character.Minimal repro:
Fix
Convert to
[]runeso both the length check and the slice operate on Unicode codepoints: