Switch season rank API to user achievement endpoint - #192
Open
ToxicBiohazard wants to merge 1 commit into
Open
Conversation
Use /v4/user/achievement/season/{userId}/{modelId} instead of the deprecated /season/end route.
Co-authored-by: Cursor <cursoragent@cursor.com>
ToxicBiohazard
requested review from
dimoschi and
makelarisjr
as code owners
September 7, 2026 15:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 66.54% 66.60% +0.06%
==========================================
Files 54 54
Lines 3177 3177
==========================================
+ Hits 2114 2116 +2
+ Misses 1063 1061 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply.Proposed changes
Update
get_season_rankto callv4/user/achievement/season/{userId}/{modelId}instead of the oldv4/season/end/{seasonId}/{userId}endpoint.Per @shad0wn0mad (platform), we were asked to switch to this endpoint; they confirmed the response schema is the same, so existing rank/tier parsing is unchanged.
Also adds unit coverage for the new URL and empty-data handling.
Checklist
Put an
xin the boxes that apply.doc.
Additional context
{API_V4_URL}/season/end/{SEASON_ID}/{htb_uid}{API_V4_URL}/user/achievement/season/{htb_uid}/{SEASON_ID}Made with Cursor