You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for taking the time to make this PR. However, I don't understand the intent!?
If the intent of issue #17 was to efficiently remove multiple keys across the cluster, this PR doesn't address that. We would need to implement group.RemoveKeys(ctx, keys...)
I also don't understand the need for parallel in RemoveKeys(parallel=true) as the LRU implementation uses a mutex which would negate the benefits of any concurrency. Even when using Otter cache, the benefits would be minimal to non-existent as there is more overhead in setting up the go routines than in removing the items from the cache.
Is your intent to efficiently remove multiple keys across the cluster?
@thrawn01 Thanks for reviewing the PR. I think we need to align clearly on the intent. I can close this PR and we can revisit it once the intent is clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveKeysto theCacheinterface and implement it for mutexCache and OtterCacheThis PR should address the issue raised #17. cc: @thrawn01