MVVM Refactor Phase 1: App shell, Settings and Home - #49
Open
kara-melvin wants to merge 16 commits into
Open
Conversation
added 16 commits
June 22, 2026 14:03
…hot message as state helper).
…e DI bindings in GlobalApp.kt. This wraps both prefs files (settings/project_mesh_prefs) and exposes StateFlows from prefs with single-writer setters.
…s. Removed redundant coroutine calls/navigation code. Tested on 1 physical device.
…nActivity still uses its old state). AppViewModel is the first consumer of StateViewModel.
…now route through SettingsRepository setters, Home collects deviceName and the server-restart toast lives in a temporary Settings-composable. MainActivity's setContent block is rewritten onto AppViewModel with collectAsStateWithLifeCycle, deep-link parsing and LocalUtil.applyLocale. Device test works.
…server restarts. Toasts are migrated to userMessage state. SettingsScreen drops all 6 callbacks and collects our new immutable state. AppNavHost's Settings composable collapses to SettingsScreen().
…sly from SettingsRepository before launching.
…el. This left AppViewModel with no userMessage producer. We pulled out the dead code.
…Model + 4 loose stateflows. deviceName and concurrency_supported now mirror SettingsRepository. HomeScreen loses its deviceName param, StartHomeScreen loses its viewModel default param
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the app shell (AppViewModel), SettingsScreen, and HomeScreen to the new StateViewModel
single-immutable-state pattern.base class and UserMessage (one-shot messages as state)