feat: pass through fallback parameter for HTTP calls - #9277
Open
shivanee-p wants to merge 3 commits into
Open
Conversation
shivanee-p
added this pull request to stack #9275
September 9, 2026 21:14
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the fallback API call creation in fallback.ts to pass a fallback flag to _createApiCall, and adds corresponding unit tests to verify this behavior. The review feedback correctly identifies that hardcoding true as the fallback argument ignores the actual fallback parameter (which can be true, false, or 'rest'), and suggests using fallback ?? true instead to preserve the parameter's value.
shivanee-p
force-pushed
the
shivaneep-o11y-http-tracing
branch
from
September 9, 2026 21:18
547c4de to
1c3c038
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-http-tracing
branch
from
September 9, 2026 21:24
1c3c038 to
eddcb84
Compare
Contributor
Author
|
Note: linter failures in apiCallable.ts ae resolved in #9278 |
shivanee-p
marked this pull request as ready for review
September 9, 2026 21:53
shivanee-p
force-pushed
the
shivaneep-o11y-http-tracing
branch
2 times, most recently
from
September 10, 2026 18:37
23228f6 to
e2b5e2e
Compare
shivanee-p
removed this pull request from stack #9275
September 10, 2026 18:41
shivanee-p
added this pull request to stack #9282
September 10, 2026 18:42
shivanee-p
force-pushed
the
shivaneep-o11y-http-tracing
branch
from
September 11, 2026 18:08
e2b5e2e to
6b5bd97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass through
trueas the fallback parameter to createApiCall() to account for HTTP calls and update unit tests accordingly