perf(spanner): optimize prepareGapicRequest dispatch and eliminate deep cloning - #9271
perf(spanner): optimize prepareGapicRequest dispatch and eliminate deep cloning#9271olavloite wants to merge 1 commit into
Conversation
olavloite
commented
Sep 9, 2026
olavloite
commented
- Dispatch RPCs synchronously once the project ID is resolved, eliminating an asynchronous auth callback hop on every query and mutation.
- Avoid recursive deep-cloning (extend) of request payloads and GAX options on the hot path by inspecting only top-level resource name keys.
- Coalesce concurrent auth.getProjectId lookups during client cold start.
- Fix duplicate RPC execution in wrappedRequestFn for Promise-based calls.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes prepareGapicRequest_ in the Spanner class by avoiding unnecessary deep cloning of reqOpts when the project ID is already cached, and introduces a helper function hasProjectIdToken to detect placeholders. The reviewer's feedback highlights critical issues regarding potential double-callback invocations if a callback throws an error, and recommends deep cloning gaxOpts instead of shallow copying it to protect the user's original configuration from accidental mutation.
…ep cloning - Dispatch RPCs synchronously once the project ID is resolved, eliminating an asynchronous auth callback hop on every query and mutation. - Avoid recursive deep-cloning (extend) of request payloads and GAX options on the hot path by inspecting only top-level resource name keys. - Coalesce concurrent auth.getProjectId lookups during client cold start. - Fix duplicate RPC execution in wrappedRequestFn for Promise-based calls.
9912bda to
d90997f
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new helper function hasProjectIdToken and refactors prepareGapicRequest_ in the Spanner client to coalesce concurrent auth.getProjectId calls, preventing redundant asynchronous lookups. It also improves error handling, ensures request IDs are attached to stream and callback errors, and adds comprehensive unit tests. The reviewer suggested optimizing the first-request path by bypassing auth.getProjectId entirely if a resolved projectId is already provided in the constructor.
1 participant
