Support custom mime-types for attachments in OpenHTF and Steamengine converters. - #1327
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_971137568
branch
4 times, most recently
from
August 28, 2026 06:24
c13e649 to
365379d
Compare
…converters. This change updates mfg_event_converter and test_runs_converter to populate the mime_type field for attachments when a custom mime-type is provided, rather than defaulting to BINARY. Additionally, mfg_event_util is updated to set the mime_type field for attachments when the inferred type is OTHER, and support for HTML attachments is added. PiperOrigin-RevId: 972372753
copybara-service
Bot
force-pushed
the
test_971137568
branch
from
August 28, 2026 06:28
365379d to
f777229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support custom mime-types for attachments in OpenHTF and Steamengine converters.
This change updates mfg_event_converter and test_runs_converter to populate the mime_type field for attachments when a custom mime-type is provided, rather than defaulting to BINARY. Additionally, mfg_event_util is updated to set the mime_type field for attachments when the inferred type is OTHER, and support for HTML attachments is added.