Implement incremental LOI sync - #3918
Merged
Merged
Conversation
andreia-ferreira
requested a deployment
to
e2e-approval
September 2, 2026 17:08 — with
GitHub Actions
Waiting
andreia-ferreira
requested a deployment
to
e2e-approval
September 4, 2026 12:58 — with
GitHub Actions
Waiting
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3918 +/- ##
============================================
+ Coverage 69.75% 69.99% +0.24%
- Complexity 2009 2034 +25
============================================
Files 422 424 +2
Lines 11594 11648 +54
Branches 1511 1522 +11
============================================
+ Hits 8087 8153 +66
+ Misses 2737 2722 -15
- Partials 770 773 +3
🚀 New features to boost your workflow:
|
andreia-ferreira
force-pushed
the
andreia/3867/avoid-sync-all-lois
branch
from
September 8, 2026 18:36
52c6ee3 to
3e7780a
Compare
andreia-ferreira
requested a deployment
to
e2e-approval
September 8, 2026 18:37 — with
GitHub Actions
Waiting
andreia-ferreira
requested a deployment
to
e2e-approval
September 8, 2026 20:26 — with
GitHub Actions
Waiting
andreia-ferreira
requested a deployment
to
e2e-approval
September 8, 2026 20:45 — with
GitHub Actions
Waiting
andreia-ferreira
marked this pull request as ready for review
September 8, 2026 20:45
shobhitagarwal1612
requested changes
Sep 9, 2026
shobhitagarwal1612
left a comment
Member
There was a problem hiding this comment.
Can we break this PR into 2 parts? First introduces the necessary room tables, daos, etc. Second one with the rest of the changes?
andreia-ferreira
marked this pull request as draft
September 9, 2026 09:31
andreia-ferreira
force-pushed
the
andreia/3867/avoid-sync-all-lois
branch
from
September 9, 2026 13:04
33a3e50 to
4c97b1b
Compare
andreia-ferreira
requested a deployment
to
e2e-approval
September 9, 2026 13:04 — with
GitHub Actions
Waiting
andreia-ferreira
force-pushed
the
andreia/3867/avoid-sync-all-lois
branch
from
September 9, 2026 16:52
4c97b1b to
b77928a
Compare
andreia-ferreira
temporarily deployed
to
e2e-approval
September 9, 2026 16:53 — with
GitHub Actions
Inactive
andreia-ferreira
marked this pull request as ready for review
September 9, 2026 17:03
Collaborator
Author
|
done! This PR is ready for review now that most of the Room changes have been merged |
4 tasks
andreia-ferreira
requested a deployment
to
e2e-approval
September 10, 2026 10:38 — with
GitHub Actions
Waiting
andreia-ferreira
temporarily deployed
to
e2e-approval
September 10, 2026 13:57 — with
GitHub Actions
Inactive
shobhitagarwal1612
approved these changes
Sep 10, 2026
andreia-ferreira
temporarily deployed
to
e2e-approval
September 10, 2026 15:54 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3867
FCMs now carry
deletedandloiId, which we apply straight as a local delete rather than discovering it through a full read. That's only a shortcut, so before each incremental sync we compare the server's LOI count against the local one and fall back to a full read if needed.A full read still happens in the following cases:
The count operation used to detect delete cases bills 1 read per 1K LOIs so it is lightweight, but soft deletion on the server side should be a future improvement for this implementation.
@shobhitagarwal1612 PTAL?