Skip to content

feat: Add enterprise level secret scanning custom patterns support - #4431

Open
tanayarun wants to merge 1 commit into
google:masterfrom
tanayarun:secret-scanning-custom-patterns-enterprise
Open

feat: Add enterprise level secret scanning custom patterns support#4431
tanayarun wants to merge 1 commit into
google:masterfrom
tanayarun:secret-scanning-custom-patterns-enterprise

Conversation

@tanayarun

Copy link
Copy Markdown
Contributor

Adds support for managing secret scanning custom patterns at the
enterprise level: list, create, update, and delete.

Related to #4381. This is the third and final PR to fully resolve the
issue.

  • Added ListCustomPatternsForEnterprise, CreateCustomPatternsForEnterprise,
    UpdateCustomPatternForEnterprise, DeleteCustomPatternsForEnterprise to
    SecretScanningService, reusing the request/response types and
    SecretScanningCustomPatternListOptions from feat: Add repo-level secret scanning custom patterns support #4397
  • Ran go generate ./... to update iterators and doc comment URLs
  • Added table driven tests for all four methods

@tanayarun

Copy link
Copy Markdown
Contributor Author

Hey, @gmlewis,
Can you review the pr and lemme know the required changes.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 5, 2026
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (40d29ba) to head (bfd552e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4431   +/-   ##
=======================================
  Coverage   97.54%   97.55%           
=======================================
  Files         194      194           
  Lines       19836    19892   +56     
=======================================
+ Hits        19350    19406   +56     
  Misses        268      268           
  Partials      218      218           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants