Skip to content

Skip more tests under Java 8. #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 11, 2026
+3 −0
Merged

Skip more tests under Java 8. #2140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions value/src/it/functional/src/test/java/com/google/auto/value/AutoValueJava8Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ interface Builder {

@Test
public void testInheritedGetterRemainsNullable() throws NoSuchMethodException {
assumeTrue(javacHandlesTypeAnnotationsCorrectly);
// Ensure that the implementation has `@Nullable String thing()`.
StringThing instance = new AutoValue_AutoValueJava8Test_StringThing(null);
Method getter = instance.getClass().getDeclaredMethod("thing");
Expand All @@ -352,6 +353,7 @@ public void testInheritedGetterRemainsNullable() throws NoSuchMethodException {

@Test
public void testInheritedBuilderGetterRemainsNullable() throws NoSuchMethodException {
assumeTrue(javacHandlesTypeAnnotationsCorrectly);
StringThingWithBuilder instance = StringThingWithBuilder.builder().setThing(null).build();
Method getter = instance.getClass().getDeclaredMethod("thing");
assertThat(getter.getAnnotatedReturnType().getAnnotations()).asList().contains(nullable());
Expand Down Expand Up @@ -1211,6 +1213,7 @@ public abstract static class Builder<T> {

@Test
public void typeParameterBuilderFieldsAreNullable() throws ReflectiveOperationException {
assumeTrue(javacHandlesTypeAnnotationsCorrectly);
assertThrows(NullPointerException.class, () -> NotNullableVariableBound.builder().setT(null));

// Even though neither t() nor string() has a @Nullable return type, the corresponding builder
Expand Down
Loading