feat(core): add Gemini 3.6 Flash and 3.5 Flash-Lite model configurations - #28673
feat(core): add Gemini 3.6 Flash and 3.5 Flash-Lite model configurations#28673Blackmanx wants to merge 3 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the latest Gemini 3.6 Flash and 3.5 Flash-Lite models. It updates the core model configuration, resolution logic, and internal tool settings to leverage these new models while maintaining backward compatibility and policy chain integrity. Additionally, it includes necessary adjustments to documentation, schemas, and test suites to reflect these changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/L
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for the gemini-3.6-flash and gemini-3.5-flash-lite models, updating configurations, policies, model resolution logic, and tests. It also adds a mechanism to strip unsupported sampling parameters for these models to prevent invalid API requests. The feedback highlights a test pollution risk due to module-level global mutable state and points out two test description mismatches in models.test.ts where the descriptions were updated to reference gemini-3.6-flash but the assertions still expect gemini-3.5-flash.
9e26fad to
6c94ae1
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds support for the new gemini-3.6-flash and gemini-3.5-flash-lite models across configuration files, policy chains, chat compression services, and processors. It also introduces a mechanism in ModelConfigService to strip unsupported sampling parameters for these models to prevent invalid API requests. However, the review feedback highlights that the newly introduced useGemini3_6Flash flag is not fully integrated, as it is missing from the signatures and implementations of the model resolution functions (resolveModel, resolveClassifierModel) and is not passed to getAutoModelDescription within getAvailableModelOptions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for the gemini-3.6-flash and gemini-3.5-flash-lite models across the codebase. The changes include updating model configuration definitions, fallback policies, alias resolution logic, and chat compression services. Additionally, a new helper method removeUnsupportedSamplingParameters was added to ModelConfigService to strip unsupported penalties and custom sampling values for these models to prevent invalid requests. Relevant tests and documentation have been updated accordingly. There are no review comments, so no further feedback is provided.
Note: Security Review did not run due to the size of the PR.
Summary
This PR adds support and model resolution configuration for Gemini 3.6 Flash and Gemini 3.5 Flash-Lite in
packages/core.Details
thinking,multimodalToolUse), aliases, and Code Assist-compatible IDs forgemini-3.6-flashandgemini-3.5-flash-lite.useGemini3_6Flashas a separate resolution condition and propagates it through direct resolution, classifier resolution, policy chains, and Auto model descriptions, preserving the existing Gemini 3.5 Flash rollout and Gemini 2.5 Flash fallback behavior.Related Issues
Related to #28483 and #28625.
How to Validate
Expected result: every command exits successfully. The full local validation passed, including 6,957 CLI tests, 7,771 core tests, 145 A2A tests, 134 script tests, and 17 SEA-launch tests.
Pre-Merge Checklist