[bot] Merge master/a6edd0de into rel/dev - #1786
Merged
Merged
Conversation
AIDA is deprecated. aida-mcp stopped at 0.13.0 (2026-04-02), declares mcp>=1.25.0 with no upper bound and so cannot import against mcp 2.x, and gdc-nas, gdc-ui and gdc-mastercard-panther have all removed it already. This repository was the last one still wired to it, with the server disabled locally anyway. The shape here follows gdc-nas#22202, scaled down for nine packages. What AIDA left behind was worse than nothing: AGENTS.md and the Cursor, Junie and JetBrains rule files were gitignored generated stubs pointing at MCP tools that no longer answer; every package rule ended with a Dependencies footer naming technologies/python and technologies/testing, which exist nowhere in the tree; and gooddata-eval had no rule at all. Rules are now tracked -- a root AGENTS.md plus one per package, each with a CLAUDE.md importing its sibling. This also restores repository knowledge that AIDA's February migration deleted and its generic embedded profiles never replaced: the VCR cassette recording loop, the commit conventions, the package map, the generated-client warning and the Python conventions, updated for ty rather than mypy. Three skills cover the workflows history shows recurring most: cassette re-recording (100 commits mention cassettes, and the top six churn paths over the last 400 commits are all fixture directories), api-client regeneration, and commits. Each package file was then audited against its own source, which found twelve factual errors. Four were in gooddata-sdk and two of those came from AIDA's rule file, carried over unchecked: - The client example passed host= and token= as keywords. The parameters are host_ and token_, and create() also takes **custom_headers_, so the example raises TypeError while the keyword copies are accepted as HTTP headers. - "Services grouped by prefix catalog_*, compute_*, insights_*, tables_*" described a convention that does not exist. The file now lists the fourteen real properties. - export was filed under compute. It is its own service. - "Visualization services: insights, dashboards" claimed dashboard support that visualization.py does not have. The rest: gooddata-dbt reads gooddata.yml, not gooddata.yaml (the gdc CLI reads gooddata.yaml, so both files now state the difference); gooddata-flight-server's tests use checked-in certs, so make dev-certs is not a pytest prerequisite; gooddata-pandas' method list implied SeriesFactory has for_visualization; tests-support sorts through a five-key allowlist rather than broadly; and four gooddata-eval module roles were wrong, with trace linking under core/agentic/ rather than core/langfuse/. Each file now opens with what the package is for and carries the verified gotchas an agent would otherwise rediscover the hard way -- among them that gooddata-pipelines full_load() deletes every record absent from its input, that gooddata-sdk layout path defaults bind Path.cwd() at import time, that editing tests-support normalization needs the consumers' tox environments recreated, and that a new gooddata-eval agentic kind defaults to workspace-mutating. Commit format becomes enforceable for the first time. .gitlint pointed extra-path at packages/repo-tools/src/quiver_monorepo/, a path from another repository that has never existed here, and make dev ran a bare `pre-commit install`, which does not wire up the commit-msg stage gitlint needs. Both are fixed, the rule gains a required-trailer check for jira and risk, and default_stages is pinned so the copyright hook cannot rewrite the commit message once that stage is installed. The staging make targets interpolated the token and data source password into recipe lines, which make echoes on every run and prints under -n even from an @-prefixed line, and passed them in the sub-make's argv where ps exposes them to any user on the host. The recipes now read both from the environment as shell variables and are @-prefixed, with the root Makefile exporting them so a .env value reaches the recipe the same way an exported one does. Two documented workflows did not match the code and are fixed: the gooddata-pipelines README called UserFullLoad.from_list_of_dicts(), which exists nowhere in the package, and CONTRIBUTING's staging section named TOKEN where the targets require STAGING_ADMIN_TOKEN, omitted STAGING_DS_PASSWORD entirely, and claimed the token reaches pytest as a --gd-test-token flag rather than an environment variable. That flag appears nowhere in the repository. scripts/validate_python.sh is removed: nothing but AIDA's validate_command called it, and its trailing-JSON contract existed only for AIDA's external_json processor. AGENTS.md documents the make targets instead. Also recorded, not fixed here: staging-tests.yaml exports only TOKEN, so a triggered run fails at its first step. Recent runs have been skipped rather than executed, which is why it stayed invisible. Fixing it needs a repository secret for the data source password. jira: trivial risk: nonprod
chore(repo): replace AIDA MCP with tracked AGENTS.md and CLAUDE.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1786 +/- ##
========================================
Coverage 81.70% 81.70%
========================================
Files 275 275
Lines 19848 19848
========================================
Hits 16217 16217
Misses 3631 3631 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to a6edd0d (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/34220873663).