Skip to content

Build the freeze job's benchmark optimized #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
godofecht merged 1 commit into from
Sep 7, 2026
Merged

Build the freeze job's benchmark optimized #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/remaining-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,13 @@ jobs:
env:
FLOW_HEADLINE_COMMAND: ${{ github.workspace }}/.flow-toolchain/flow run benchmarks/bench_flow_v2.flow
FLOW_HOST: python
FLOW_OPT_LEVEL: "0"
# This job's artifact is what the freeze step promotes to
# headline_result_v2.json, so it decides the published numbers. At -O0
# it was publishing an unoptimized Flow against scikit-learn's
# optimized wheels, which is the comparison the -O3 move in flow.yml
# already corrected everywhere else. Left here, main froze 16 of 19
# while every other measurement of the same commit read 19 of 19.
FLOW_OPT_LEVEL: "3"
FLOW_LDFLAGS: "-lm -lopenblas lib/scikit/flow_time.c lib/scikit/flow_parallel.c"
# Both sides call into OpenBLAS, and its thread count was left to
# runtime detection. Pinned to 1 on a trial run, LogisticRegression on
Expand Down
Loading