Add a benchmark for filter_missing - #1424
Merged
Merged
Conversation
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
September 1, 2026 23:03
kurtmckee
requested changes
Sep 2, 2026
sirosen
force-pushed
the
benchmark-filter-missing
branch
from
September 2, 2026 15:49
ddbe892 to
f7b3e9e
Compare
kurtmckee
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a benchmark for filtering out MISSING values from a wide and deep request body.
Note
This is a benchmark developed during review of #1423, and is not safe to add to
mainuntil that fix merges.@kurtmckee, I'm especially interested in what you think of this benchmark as the author of the original fix PR. I'm using a cherry-pick of this work to evaluate potential improvements.
(I think some measure of perf testing is important to validate my assumptions. I had some initial feedback that I scrapped once I actually measured the effects.)
EDIT: I added a small second benchmark which grabs testing registered response data as "typical" JSON data. This doesn't demonstrate any perf wins or losses in my testing across branches, but serves as a good "do no harm" signal.