Skip to content

Update CLI completions for bash/zsh; add a CLI completion for fish - #1284

Merged
kurtmckee merged 5 commits into
mainfrom
fish-completer
Sep 3, 2026
Merged

Update CLI completions for bash/zsh; add a CLI completion for fish#1284
kurtmckee merged 5 commits into
mainfrom
fish-completer

Conversation

@kurtmckee

Copy link
Copy Markdown
Member

Other

  • Update CLI completions for bash and zsh shells.
  • Add a CLI completion for fish shell.

@sirosen sirosen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also will need to update the docs.

Looking back over this, I would like to find a more elegant way of getting nice completion printing. But that can be a separate enhancement.

@kurtmckee

Copy link
Copy Markdown
Member Author

We also will need to update the docs

Where are these docs located? I searched for the text --completion and --bash-completion and found nothing in the rest of the repo.


import click

# When click versions are updated, re-run the CLI-completion generator commands for:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this comment to the pyproject.toml file where we define the click version?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deliberately chose only to mention "update the shell_completion.py file" in pyproject.toml because anything more than one line will prevent us from seeing context in diffs.

Lemme see if I can cram a bit more info into the line I added to pyproject.toml without it spilling across to a second line.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs might be up to three lines, so I've allowed the instructions to spill onto a second line. See what you think! 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks great; thanks

@kurtmckee
kurtmckee merged commit 20945dd into main Sep 3, 2026
6 checks passed
@kurtmckee
kurtmckee deleted the fish-completer branch September 3, 2026 14:47
@sirosen

sirosen commented Sep 3, 2026

Copy link
Copy Markdown
Member

Just to close a loop and leave a record: Kurt and I chatted about docs.
Some of the CLI docs are part of the docs.globus.org repo, so you can't find them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants