Update CLI completions for bash/zsh; add a CLI completion for fish - #1284
Conversation
sirosen
left a comment
There was a problem hiding this comment.
We also will need to update the docs.
Looking back over this, I would like to find a more elegant way of getting nice completion printing. But that can be a separate enhancement.
Where are these docs located? I searched for the text |
|
|
||
| import click | ||
|
|
||
| # When click versions are updated, re-run the CLI-completion generator commands for: |
There was a problem hiding this comment.
Could you add this comment to the pyproject.toml file where we define the click version?
There was a problem hiding this comment.
I deliberately chose only to mention "update the shell_completion.py file" in pyproject.toml because anything more than one line will prevent us from seeing context in diffs.
Lemme see if I can cram a bit more info into the line I added to pyproject.toml without it spilling across to a second line.
There was a problem hiding this comment.
Diffs might be up to three lines, so I've allowed the instructions to spill onto a second line. See what you think! 👍
There was a problem hiding this comment.
Yep, that looks great; thanks
|
Just to close a loop and leave a record: Kurt and I chatted about docs. |
Other