chore(deps-core): update octokit packages to types v17 and rest-endpoint-methods v18 - #3162
Merged
Conversation
…lugin-rest-endpoint-methods v18
setchy
approved these changes
Aug 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Lands the two open Renovate octokit bumps together, because neither can pass CI on its own:
@octokit/types16 → 17@octokit/plugin-rest-endpoint-methods17 → 18Both PRs fail
tsc --noEmitwith variations ofType '{ id: number | bigint; ... }' is not assignable to type '{ id: number; ... }'.Root cause
@octokit/openapi-typesv28 widened every entityidfromnumbertonumber | bigint, and the repo depends on the octokit packages as separate pinned versions:openapi-typesviaidcomponents[...]inforges/github/types.ts28.0.0number | bigintEndpoints[...]inforges/github/types.ts@octokit/types@16→^27.0.0numberoctokit.rest.*return typesplugin-rest-endpoint-methods@17→@octokit/types@16→^27.0.0numbermaincarries two copies of@octokit/openapi-types(27.0.0 and 28.0.0) and only typechecks today because the mismatch is bridged byascasts, which stay legal while{id: number}is assignable to{id: number | bigint}.Bumping one package moves a subset of those rows to
bigintand breaks the bridge in whichever direction was bumped, which is why each PR fails in a different file:Endpointstobigintwhileoctokit.rest.*stays onnumber→ fails inuseAccountsStore.test.tsoctokit.rest.*tobigintwhileEndpointsstays onnumber→ fails inclient.tsBumping both collapses the lockfile to a single
@octokit/openapi-types@28.0.0, so every row above agrees onnumber | bigint. No application code changes are required.Preventing recurrence
:separateMultipleMajorReleasesputs one target major per branch, which is what split the shared octokit monorepo group intorenovate/major-17-…andrenovate/major-18-…in the first place. Added a package rule pinning@octokit/**to a single group withseparateMultipleMajor: falseso future octokit majors arrive as one PR. Verified withrenovate-config-validator.Verification
tsc --noEmit— cleanpnpm test— 165 files, 1295 tests passedvp check— 420 files formatted, 0 lint errorspnpm install --frozen-lockfile— passes, including the supply-chain /minimumReleaseAgegateSupersedes #3155 and #3154; both should close automatically once this merges.
Note
GitHub Actions is in a major outage (started 2026-08-06 15:22 UTC) and webhook-triggered workflows are only being gradually restored, so no
pull_requestCI has run on this repo since ~17:53 UTC — every currently open PR shows only the CodeQL checks. The checks above will need a re-run once Actions recovers. All four gates were verified locally in the meantime (see Verification).