Fix excessive blank lines before generated footer in safe-output bodies

[Copilot]

Generated issues, discussions, and pull requests rendered with a large empty gap between the body content and the > Generated by ... footer, as seen in the linked issue.

Two sources of stray newlines compounded:

• generateFooterWithMessages unconditionally prefixed the attribution line with "\n\n", even when guardNotices was empty — so the returned footer started with blank lines.
• create_issue.cjs, create_discussion.cjs, and create_pull_request.cjs each pushed two empty bodyLines entries before the footer.

Changes

• messages_footer.cjs: only insert the "\n\n" separator when guard notices (detection caution, blocked domains, DIFC filtering) are actually present, and trim trailing whitespace off the notices block.
• create_issue.cjs / create_discussion.cjs / create_pull_request.cjs: push a single blank separator line instead of two.
• messages.test.cjs: regression test asserting the footer starts directly with > Generated by ... when there are no guard notices.

// before
let footer = guardNotices + "\n\n" + getFooterMessage(ctx);
// after
let footer = guardNotices ? guardNotices.trimEnd() + "\n\n" + getFooterMessage(ctx) : getFooterMessage(ctx);

Recompiled workflow lock files are included since the setup JS is bundled into them.

• Fixes [container-image-scan] Container findings for test-image #50507

---

Run: https://github.com/github/gh-aw/actions/runs/31011720441

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.95 AIC · ⌖ 6.77 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the implementation label and has 0 new lines of code in business logic directories.

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

[Copilot]

Pull request overview

Fixes excessive spacing before safe-output footers.

Changes:

• Normalizes footer separation based on guard notices.
• Reduces separator lines in generated issue, discussion, and pull request bodies.
• Adds regression coverage for footers without guard notices.

Show a summary per file

File	Description
actions/setup/js/messages.test.cjs	Tests footer spacing without notices.
actions/setup/js/messages_footer.cjs	Adjusts guard-notice/footer separation.
actions/setup/js/create_issue.cjs	Removes an extra issue-body separator.
actions/setup/js/create_discussion.cjs	Removes an extra discussion-body separator.
actions/setup/js/create_pull_request.cjs	Removes an extra pull-request-body separator.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 5/5 changed files
• Comments generated: 1
• Review effort level: Balanced

[github-actions]

The fix is correct and well-scoped.

• messages_footer.cjs: correctly gates the `

separator onguardNotices` being truthy — empty string is falsy in JS, so no blank lines are emitted when there are no guard notices.

• The three .cjs files consistently reduce the double-blank push to a single separator, matching the intent.
• The regression test directly validates the reported symptom.

No blocking issues found.> 🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 16.3 AIC · ⌖ 10.3 AIC · ⊞ 5.4K

[github-actions]

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — approving with one minor observation on test coverage.

📋 Key Themes & Highlights

Key Themes

• Root cause properly addressed: both compounding sources of stray blank lines are fixed — the footer separator and the caller push.
• Regression test added: the happy-path (no guard notices) is now covered; see inline comment for a suggested complementary test.

Positive Highlights

• ✅ Minimal, surgical diff across exactly the files that mattered
• ✅ guardNotices.trimEnd() prevents trailing whitespace from leaking into the separator
• ✅ Consistent fix applied to all three callers (issue, discussion, PR)
• ✅ PR description accurately explains both root causes and the fix strategy

> 🧠 *Reviewed using Matt Pocock's skills by [Matt Pocock Skills Reviewer](https://github.com/github/gh-aw/actions/runs/31010256034)* · sonnet46 · 26 AIC · ⌖ 7.88 AIC · ⊞ 7.1K > _{Comment /matt to run again}

[github-actions]

[/tdd] The test covers only the no-guard-notices path. A complementary test for when guardNotices is non-empty would protect the intentional `

` separator in that branch — without it, a future regression there would go undetected.

@copilot please address this.

[github-actions]

Verdict: no blocking issues

Small, well-targeted fix: generateFooterWithMessages now only inserts the \n\n separator when guard notices exist and trims trailing whitespace off the notices block; the three create_*.cjs callers were updated to push a single blank separator line instead of two. Logic checked against all three call sites (issue/discussion/PR) and matches the regression test added in messages.test.cjs.

💡 Minor nit (non-blocking)

Line 738 in messages_footer.cjs has a leftover duplicate comment line (// Attribution footer line comes after any guard notices) immediately followed by the new 3-line comment restating the same thing. Harmless but slightly redundant — could be squashed into one comment block.

> 🔎 *Code quality review by [PR Code Quality Reviewer](https://github.com/github/gh-aw/actions/runs/31010256052)* · auto · 33.3 AIC · ⌖ 4.86 AIC · ⊞ 7.9K > _{Comment /review to run again}

[github-actions]

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 100/100 — Excellent

Analyzed 1 test: 1 design, 0 implementation, 0 violations.

📊 Metrics (1 test)

Metric	Value
Analyzed	1 (Go: 0, JS: 1)
✅ Design	1 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	1 (100%)
Duplicate clusters	0
Inflation	No (ratio: 1.1:1)
🚨 Violations	0

Test	File	Classification	Status
should not start with blank lines when there are no guard notices	actions/setup/js/messages.test.cjs:798	Design test	✅ Excellent

Quality Highlights

• Focused bug-fix test — Single new test validates the exact regression being prevented (no blank lines before footer when guard notices absent)
• Behavioral coverage — Test verifies user-visible output formatting, not implementation details
• Minimal test inflation — 8 test lines vs. 7 production lines (1.1:1 ratio, well under 2:1 threshold)
• Clean assertions — Direct expect().toBe() pattern with clear intent
• Edge case coverage — Test covers the previously broken scenario (empty guard notices)

Verdict

✅ passed. 0% implementation tests (threshold: 30%). High-quality targeted fix with excellent test coverage.

🧪 Test quality analysis by Test Quality Sentinel · haiku45 · 18.7 AIC · ⌖ 4.99 AIC · ⊞ 7.7K · ◷
_{Comment /review to run again}

[github-actions]

✅ Test Quality Sentinel: 100/100. 0% implementation tests (threshold: 30%).

[gh-aw-bot]

@copilot Please take another pass on this PR.

• lint-js is failing: https://github.com/github/gh-aw/actions/runs/31010256046/job/92320349002
• The branch refresh has been requested automatically.
• After addressing the failure, please run the pr-finisher skill and update/resolve any remaining review feedback as appropriate.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.95 AIC · ⌖ 6.77 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}