Skip to content

chore: update Node.js version and docs to match - #500

Open
shusak wants to merge 5 commits into
github-community-projects:mainfrom
capitalone-contributions:shusak-pma-nodejs-update
Open

chore: update Node.js version and docs to match#500
shusak wants to merge 5 commits into
github-community-projects:mainfrom
capitalone-contributions:shusak-pma-nodejs-update

Conversation

@shusak

@shusak shusak commented Sep 3, 2026

Copy link
Copy Markdown

Pull Request

Updates the version of Node.js to latest 24.20.0 release. Also did doc updates to only allow for Node.js 24.x due to package manager differences and more reflective of the version in .nvmrc.

Proposed Changes

Updating to specify only Node 24.x

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run format and fix any formatting issues that have been introduced
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests

@shusak
shusak requested review from a team as code owners September 3, 2026 17:30
Comment thread package.json
"vitest": "4.1.5"
},
"engines": {
"node": "^22 || ^24"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically a breaking change for downstream users

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep Node.js 22 support and testing but specify devEngines to make the supported versions for development more explicit?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally removed devEngines in #397 because the package manager settings there broke dependabot, but we could likely add the runtime portion back here to cover this intent?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While a breaking changing, we have no way to version this appropriate yet until it hits 1.0... so what do we want to do here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a strong reason to drop Node.js 22 support as part of the version alignment here?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was concerned with the potential incompatibilities between npm 10.x included with Node 22.x and npm 11.x included with Node 24.x.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should only impact the Node.js version used for the project, I believe. As long as we restrict the dev version we should be good 🙏🏻

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants