chore(deps): update Cocoa SDK to v9.25.0 - #6409
Conversation
507d83f to
f774131
Compare
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
4e98712 to
4a42ca3
Compare
| } | ||
|
|
||
| sentry_cocoa_version = '9.19.1' | ||
| sentry_cocoa_version = '9.20.0' |
There was a problem hiding this comment.
Bug: The podspec references Sentry Cocoa SDK version 9.20.0, which is not available on CocoaPods. This will cause pod install to fail for default installations.
Severity: CRITICAL
Suggested Fix
Since version 9.20.0 is not on CocoaPods, either revert the version update in the podspec to a version that is available on CocoaPods, or update the logic to make SPM the default. Alternatively, update the CI and documentation to enforce setting SENTRY_USE_SPM=1 for this and future versions.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/core/RNSentry.podspec#L57
Potential issue: The pull request updates the Sentry Cocoa SDK dependency to version
9.20.0 in `RNSentry.podspec`. However, this version was not published to CocoaPods, only
to Swift Package Manager (SPM). The podspec defaults to using CocoaPods unless the
`SENTRY_USE_SPM` environment variable is explicitly set to '1'. Consequently, any user
or CI/CD process (like the `native-tests.yml` workflow) running `pod install` without
this environment variable will encounter a build failure because the specified
dependency version cannot be resolved from the CocoaPods repository.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Adding the Blocked label since this is blocking till the xcframeworks work replacing the cocoapod dependency land.
Also added the ready-to-merge label to see how the failure reflects on the CI checks.
9a1cdcc to
abb3232
Compare
abb3232 to
cde5219
Compare
📲 Install BuildsAndroid
|
cae931a to
58437c2
Compare
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b0d3373+dirty | 3842.49 ms | 1218.49 ms | -2624.00 ms |
| ef27341+dirty | 3835.20 ms | 1212.23 ms | -2622.97 ms |
| e5bb5f6+dirty | 3825.74 ms | 1217.30 ms | -2608.43 ms |
| 44c8b3f+dirty | 3849.24 ms | 1209.94 ms | -2639.31 ms |
| 68672fc+dirty | 3832.22 ms | 1228.29 ms | -2603.93 ms |
| 5748023+dirty | 3844.74 ms | 1225.49 ms | -2619.26 ms |
| 6acdf1d+dirty | 3835.35 ms | 1218.30 ms | -2617.06 ms |
| 2c735cc+dirty | 1223.33 ms | 1224.38 ms | 1.04 ms |
| 100ce80+dirty | 3843.57 ms | 1226.46 ms | -2617.12 ms |
| 9210ae6+dirty | 3834.11 ms | 1216.64 ms | -2617.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b0d3373+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| ef27341+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| e5bb5f6+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 44c8b3f+dirty | 5.15 MiB | 6.66 MiB | 1.51 MiB |
| 68672fc+dirty | 5.15 MiB | 6.71 MiB | 1.55 MiB |
| 5748023+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| 6acdf1d+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 2c735cc+dirty | 3.38 MiB | 4.74 MiB | 1.35 MiB |
| 100ce80+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 9210ae6+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 08c933b+dirty | 1204.21 ms | 1217.09 ms | 12.88 ms |
| cb5d89e+dirty | 3854.04 ms | 1228.56 ms | -2625.48 ms |
| ebc61a9+dirty | 3822.19 ms | 1201.34 ms | -2620.85 ms |
| 58dacb0+dirty | 3839.13 ms | 1211.04 ms | -2628.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 08c933b+dirty | 3.38 MiB | 4.78 MiB | 1.40 MiB |
| cb5d89e+dirty | 5.15 MiB | 6.70 MiB | 1.54 MiB |
| ebc61a9+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 58dacb0+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9bebee+dirty | 3850.15 ms | 1227.51 ms | -2622.64 ms |
| 3d377b5+dirty | 1218.48 ms | 1219.51 ms | 1.03 ms |
| 1a2e7e0+dirty | 3842.49 ms | 1220.04 ms | -2622.45 ms |
| e5bb5f6+dirty | 3826.14 ms | 1212.24 ms | -2613.90 ms |
| 6acdf1d+dirty | 3844.33 ms | 1212.96 ms | -2631.38 ms |
| 41d6254+dirty | 3845.71 ms | 1224.51 ms | -2621.20 ms |
| 9210ae6+dirty | 3815.93 ms | 1214.14 ms | -2601.79 ms |
| c004dae+dirty | 3850.32 ms | 1227.79 ms | -2622.53 ms |
| 4e0b819+dirty | 3839.05 ms | 1210.75 ms | -2628.30 ms |
| 0b5120f+dirty | 3838.39 ms | 1232.91 ms | -2605.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9bebee+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| 3d377b5+dirty | 3.38 MiB | 4.76 MiB | 1.38 MiB |
| 1a2e7e0+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| e5bb5f6+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 6acdf1d+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 41d6254+dirty | 5.15 MiB | 6.70 MiB | 1.54 MiB |
| 9210ae6+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| c004dae+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 4e0b819+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| 0b5120f+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 08c933b+dirty | 1224.53 ms | 1226.59 ms | 2.06 ms |
| cb5d89e+dirty | 3851.80 ms | 1225.70 ms | -2626.10 ms |
| ebc61a9+dirty | 3844.58 ms | 1218.91 ms | -2625.67 ms |
| 58dacb0+dirty | 3849.82 ms | 1228.28 ms | -2621.54 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 08c933b+dirty | 3.38 MiB | 4.78 MiB | 1.40 MiB |
| cb5d89e+dirty | 5.15 MiB | 6.70 MiB | 1.54 MiB |
| ebc61a9+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 58dacb0+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
c635679 to
7df6177
Compare
f36ccdf to
9e8d58f
Compare
9b6e4dd to
6271eb5
Compare
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 411.11 ms | 454.38 ms | 43.27 ms |
| d2eadf8+dirty | 414.64 ms | 454.56 ms | 39.92 ms |
| b0d3373+dirty | 557.66 ms | 579.42 ms | 21.76 ms |
| 27d9693+dirty | 419.08 ms | 469.12 ms | 50.04 ms |
| 4e0b819+dirty | 420.56 ms | 470.08 ms | 49.52 ms |
| 9474ead+dirty | 411.45 ms | 446.80 ms | 35.35 ms |
| 0bd8916+dirty | 412.77 ms | 451.31 ms | 38.54 ms |
| f9c1ed4+dirty | 431.00 ms | 466.22 ms | 35.22 ms |
| 3d536d1+dirty | 524.34 ms | 547.32 ms | 22.98 ms |
| 04207c4+dirty | 459.19 ms | 518.54 ms | 59.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| d2eadf8+dirty | 48.30 MiB | 53.48 MiB | 5.18 MiB |
| b0d3373+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| 27d9693+dirty | 49.74 MiB | 55.09 MiB | 5.34 MiB |
| 4e0b819+dirty | 49.74 MiB | 54.81 MiB | 5.07 MiB |
| 9474ead+dirty | 48.30 MiB | 53.61 MiB | 5.30 MiB |
| 0bd8916+dirty | 48.30 MiB | 53.57 MiB | 5.26 MiB |
| f9c1ed4+dirty | 49.74 MiB | 54.86 MiB | 5.12 MiB |
| 3d536d1+dirty | 49.74 MiB | 55.26 MiB | 5.52 MiB |
| 04207c4+dirty | 43.75 MiB | 48.12 MiB | 4.37 MiB |
| } | ||
|
|
||
| sentry_cocoa_version = '9.19.1' | ||
| sentry_cocoa_version = '9.25.0' |
There was a problem hiding this comment.
macOS deployment target incompatible with Cocoa SDK 9.25.0
Sentry Cocoa SDK 9.25.0 requires macOS 12 minimum, but the podspec still declares osx.deployment_target = "10.13" (line ~28). Update the podspec's macOS deployment target to match the upstream requirement, or consumers targeting macOS 10.13–11.x will hit build failures.
Evidence
- Sentry Cocoa SDK 9.25.0 release notes state the minimum deployment target was bumped to macOS 12.
RNSentry.podspecsetss.osx.deployment_target = "10.13", which is below macOS 12.- Because the xcframework path bypasses CocoaPods source dependency resolution, CocoaPods won't detect the mismatch at
pod installtime; the failure will surface during the Xcode build or link phase for macOS consumers.
Identified by Warden · code-review, find-bugs · RZL-LV7
Bumps scripts/update-cocoa.sh from 9.24.0 to 9.25.0.
Auto-generated by a dependency updater.
Changelog
9.25.0
Warning
This release raises the minimum deployment targets to macOS 12 and watchOS 9. Apps that support older OS versions must use an earlier Sentry Cocoa release.
Features
SentrySDK.feedback.enableOnShake()anddisableOnShake()to toggle the shake-to-report gesture at runtime (#8591)Fixes
durationsent for active sessions (#8612)durationis now set only when the session ends. Active sessions (including on error increments) no longer emit a bogusduration.9.24.0
Breaking Changes
Full CHANGELOG.md diff