Skip to content

ref(langchain): Remove on_agent_finish() hook #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 1 commit into from
Aug 6, 2026
+0 −21
Merged

ref(langchain): Remove on_agent_finish() hook #7059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions sentry_sdk/integrations/langchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@


try:
from langchain_core.agents import AgentFinish
from langchain_core.callbacks import (
BaseCallbackHandler,
BaseCallbackManager,
Expand Down Expand Up @@ -618,26 +617,6 @@ def on_chat_model_error(
"""Run when Chat Model errors."""
self._handle_error(run_id, error)

def on_agent_finish(
self: "SentryLangchainCallback",
finish: "AgentFinish",
*,
run_id: "UUID",
**kwargs: "Any",
) -> "Any":
with capture_internal_exceptions():
if not run_id or run_id not in self.span_map:
return

span = self.span_map[run_id]

if should_send_default_pii() and self.include_prompts:
set_data_normalized(
span, SPANDATA.GEN_AI_RESPONSE_TEXT, finish.return_values.items()
)

self._exit_span(span, run_id)

def on_tool_start(
self: "SentryLangchainCallback",
serialized: "Dict[str, Any]",
Expand Down
Loading