fix(alerts): Remove deprecated transactions dataset - #1516
Draft
mjq wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Aug 31, 2026
| @@ -33,12 +32,10 @@ const METRIC_DATASET_VALUES = new Set([ | |||
| const METRIC_DATASET_ALIASES: Record<string, string> = { | |||
Member
There was a problem hiding this comment.
You should add span: "spans" at least and I may even add transaction: "spans" and transactions: "spans" for a smoother transition.
Member
Author
There was a problem hiding this comment.
@BYK The super slick thing to do might be for requests for transaction(s) to route to spans with is_transaction:true in the query. Too magic or just magic enough? Would result in some new special case code of course.
Member
There was a problem hiding this comment.
Love it. We may print a warning/tip using the built-in system we do for gentle nudges. Like do the routing but also tell them "the right way" gently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transactionsis no longer a valid dataset for alerts (the same use cases are supported by spans). All existing alerts have been migrated off of those datasets and creating new alerts that use them has been blocked on all billing plans.Remove all references to transactions datasets from alerts code and skills.
See BROWSE-682.