fix(dif): log errors in tryProguard and tryObject catch blocks - #1513
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(dif): log errors in tryProguard and tryObject catch blocks#1513cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Three catch blocks in find.ts silently discarded errors when reading, hashing, or parsing debug-information files. Users running `debug-files find` had no way to tell why certain files were skipped. Added logger.debug() to each catch block so failures appear with --verbose. Co-authored-by: Miguel Betegón <miguelbetegongarcia@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
tryProguard()andtryObject()insrc/lib/dif/find.tscontained three silent catch blocks that discarded errors when reading, hashing, or parsing debug-information files duringdebug-files find.Root cause
Three catch blocks used bare
catch { return; }without any logging, violating the project's silent-catch prohibition. Users runningsentry debug-files findhad no way to diagnose why certain files were silently skipped.Reproduction
Any file I/O error (permissions, corrupted files, disk issues) during debug file scanning would be silently swallowed, providing no diagnostic output even with
--verbose.Fix
logger.debug()to all three catch blocks intryProguard(ProGuard UUID computation) andtryObject(format peek + debug file parse)