fix(scope-recovery): log error in hasActiveOAuthGrant catch block - #1511
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(scope-recovery): log error in hasActiveOAuthGrant catch block#1511cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The hasActiveOAuthGrant function silently swallowed all exceptions from runtime.getAuthSource(), making it impossible to diagnose database errors that could prevent the OAuth scope recovery flow from activating. Added log.debug() so failures are visible with --verbose. Co-authored-by: Miguel Betegón <miguelbetegongarcia@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
hasActiveOAuthGrant()insrc/lib/scope-recovery.tssilently swallowed all exceptions fromruntime.getAuthSource(). This violated the project's silent-catch prohibition and made it impossible to diagnose database errors that could prevent the OAuth scope recovery flow from activating.Root cause
The
catchblock returnedfalsewithout any logging, so failures ingetAuthSource()(e.g. DB corruption, missing tables) were completely invisible even with--verbose.Reproduction
Any database error during
getAuthSource()would be silently swallowed, causing the CLI to skip OAuth scope recovery without any diagnostic output.Fix
logger.debug()to the catch block so the error is visible with--verbose