Skip to content

fix: hide the redundant data-table search label #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdumay merged 3 commits into from
Aug 31, 2026
Merged

fix: hide the redundant data-table search label #2149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dbaf7f
fix(styles): keep visually-hidden out of the purge
markdumay Aug 31, 2026
eb36787
fix(test): vendor Hugo modules before the template tests
markdumay Aug 31, 2026
b8a5241
fix(deps): adopt mod-simple-datatables v4.2.1
markdumay Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion config/postcss.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,14 @@ const purgecss = purgeCSSPlugin({
'search-input',
// Bootstrap utilities used by SimpleDatatables
'float-right',
'float-left'
'float-left',
// mod-simple-datatables hides the search input's label, which would otherwise repeat
// the input's own placeholder, by passing a `visually-hidden` span as the label text.
// That class therefore only ever appears inside the module's JavaScript, never in a
// layout, so hugo_stats.json cannot record it. Core layouts happen to emit it too, but
// only on pages that render a button, spinner or carousel - a site with none of those
// would purge the class and put the duplicated label back on screen.
'visually-hidden'
],
// Classes with these patterns will be preserved along with their children
deep: [
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ require (
github.com/gethinode/mod-leaflet/v3 v3.1.3 // indirect
github.com/gethinode/mod-lottie/v3 v3.0.4 // indirect
github.com/gethinode/mod-mermaid/v5 v5.0.4 // indirect
github.com/gethinode/mod-simple-datatables/v4 v4.2.0 // indirect
github.com/gethinode/mod-simple-datatables/v4 v4.2.1 // indirect
github.com/gethinode/mod-utils/v6 v6.11.0 // indirect
github.com/nextapps-de/flexsearch v0.0.0-20260529083235-f7ed963096a0 // indirect
github.com/twbs/bootstrap v5.3.8+incompatible // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ github.com/gethinode/mod-simple-datatables/v4 v4.1.1 h1:Bidf8FA9SxBBb163D0yteTya
github.com/gethinode/mod-simple-datatables/v4 v4.1.1/go.mod h1:irmXKx2jeppfpGRsCC91vN8dA4U2nQfy2eW8bajUeJo=
github.com/gethinode/mod-simple-datatables/v4 v4.2.0 h1:n1GyPqVQ6o44awWIAiAwg/xZ6LYYQZuTQk6CuagboeI=
github.com/gethinode/mod-simple-datatables/v4 v4.2.0/go.mod h1:bIYh9MBNdBe5vzSfmymqVzdVh+RSA7yPbMfnIayg8eo=
github.com/gethinode/mod-simple-datatables/v4 v4.2.1 h1:Se1TIpqzOGcQVLZ2K8Ud7GuoEuVj/gk1zRqZ0jOR0UA=
github.com/gethinode/mod-simple-datatables/v4 v4.2.1/go.mod h1:X9j8YEPhKWhcPCdylQHwfNkAqLH8L9878XcHQLyGEc8=
github.com/gethinode/mod-utils/v6 v6.7.0 h1:DxqKUb13/6ydcntGIrUj1YD892VwarB8zGj+77CeUwM=
github.com/gethinode/mod-utils/v6 v6.7.0/go.mod h1:E5tO9w3VKaidJpu1nI8zAKmh0bddFHOIIQnudAaXQTs=
github.com/gethinode/mod-utils/v6 v6.8.0 h1:Rz/6DlPKVW0791jSsobxx4I4pKQ38H4JOEeOV+GeRzU=
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"mod:vendor": "node scripts/mod-vendor.cjs",
"mod:vendor:force": "rimraf _vendor && hugo mod vendor",
"test": "npm-run-all lint test:templates",
"pretest:templates": "pnpm mod:vendor",
"test:templates": "hugo -s tests/templates --logLevel error",
"env": "hugo env",
"precheck": "npm version",
Expand Down